Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PODMAN_BIN to CONTAINER_TOOL with backward compatibility #168

Closed
dagood opened this issue Mar 4, 2024 · 3 comments · Fixed by #305
Closed

Rename PODMAN_BIN to CONTAINER_TOOL with backward compatibility #168

dagood opened this issue Mar 4, 2024 · 3 comments · Fixed by #305
Labels
good first issue Good for newcomers kind/feature Categorizes issue or PR as related to a new feature. priority/low triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@dagood
Copy link
Contributor

dagood commented Mar 4, 2024 •
edited
Loading

This came up in #165: now that kantra will automatically fall back to docker if podman isn't present, PODMAN_BIN doesn't make quite as much sense. Renaming it to CONTAINER_TOOL would help clarify what the override is actually overriding.

Continuing to accept PODMAN_BIN and forwarding it to CONTAINER_TOOL means this doesn't need to be a breaking change. (I don't mind if this is a breaking change myself, though, just an idea.)

A name other than CONTAINER_TOOL is fine with me, it does seem like an easy pick though. I also took a look in k8s and see that name being used: https://github.com/search?q=org%3Akubernetes-sigs+CONTAINER_TOOL&type=code
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 4, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Mar 4, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Mar 4, 2024
@dagood dagood mentioned this issue Mar 4, 2024
Merged
@eemcmullan eemcmullan added priority/low good first issue Good for newcomers and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Mar 5, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 5, 2024
@konveyor-ci-bot
Copy link

This issue has been marked 'good first issue'
Please, make sure it aligns with the criteria found here

@eemcmullan eemcmullan removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. labels Mar 5, 2024
@konveyor-ci-bot konveyor-ci-bot bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. labels Mar 5, 2024
@pranavgaikwad pranavgaikwad added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 2, 2024
@konveyor-ci-bot konveyor-ci-bot bot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. labels Apr 2, 2024
@eemcmullan eemcmullan moved this from 🆕 New to 📋 Backlog in Planning May 10, 2024
@soham4abc soham4abc mentioned this issue Aug 3, 2024
Merged
@soham4abc
Copy link
Contributor

Hey, I issued a PR that might close this issue!!

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Planning Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/feature Categorizes issue or PR as related to a new feature. priority/low triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

:fix :(docs): changed env PODMAN_BIN to CONTAINER_TOOL soham4abc/kantra
4 participants
@pranavgaikwad @dagood @eemcmullan @soham4abc