Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Kantra CLI doesn't throw an error when an invalid target is specified #176

Closed
1 task done
kthatipally opened this issue Mar 14, 2024 · 2 comments · Fixed by #243
Closed
1 task done

[BUG] Kantra CLI doesn't throw an error when an invalid target is specified #176

kthatipally opened this issue Mar 14, 2024 · 2 comments · Fixed by #243
Assignees
@aufi
Labels
good first issue Good for newcomers kind/bug Categorizes issue or PR as related to a bug. priority/low triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.5.0

Comments

@kthatipally
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

v0.3.0

Priority

Undefined (Default)

Current Behavior

The analysis is running successfully even though the target specified is invalid/not in the list returned by "--list-targets"

The below command runs successfully:
.\kantra-latest.exe analyze --input C:\testing\spring-petclinic --output C:\testing\target-discovery --overwrite --target "notarget-temp"

Expected Behavior

Should return an error with a message "invalid target" specified.

How Reproducible

Always (Default)

Steps To Reproduce

The below command runs successfully:
.\kantra-latest.exe analyze --input C:\testing\spring-petclinic --output C:\testing\target-discovery --overwrite --target "notarget-temp"

Environment

- OS: windows, linux

Anything else?

No response
@kthatipally kthatipally added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 14, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Mar 14, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Mar 14, 2024
@eemcmullan eemcmullan added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 19, 2024
@kthatipally kthatipally mentioned this issue Mar 21, 2024
Closed
1 task
@pranavgaikwad pranavgaikwad added priority/low and removed needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Apr 2, 2024
@pranavgaikwad pranavgaikwad added this to the v0.4.0 milestone Apr 2, 2024
@eemcmullan eemcmullan added the good first issue Good for newcomers label Apr 9, 2024
@konveyor-ci-bot
Copy link

This issue has been marked 'good first issue'
Please, make sure it aligns with the criteria found here

@dymurray dymurray modified the milestones: v0.4.0, v0.5.0 Apr 25, 2024
@eemcmullan eemcmullan moved this from 🆕 New to 🔖 Ready in Planning May 10, 2024
aufi added a commit to aufi/kantra that referenced this issue May 27, 2024
@aufi
Validate source and target labels
195b0f8 
Adding validation for analysis source and target labels.

Fixes: konveyor#176

Signed-off-by: Marek Aufart <[email protected]>
@aufi aufi mentioned this issue May 27, 2024
Merged
eemcmullan pushed a commit that referenced this issue May 30, 2024
@aufi
🐛 Validate source and target labels (#243)
fdde270 
Validate source and target labels

Adding validation for analysis source and target labels.

Fixes: #176

Signed-off-by: Marek Aufart <[email protected]>
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Planning May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aufi aufi

Labels
good first issue Good for newcomers kind/bug Categorizes issue or PR as related to a bug. priority/low triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

🐛 Validate source and target labels aufi/kantra
5 participants
@aufi @pranavgaikwad @dymurray @eemcmullan @kthatipally