-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
occt-import-js fetched each time from the CDN #473
Comments
U mean serving the OV lib on https://3dviewer.net/ ? Or maybe we could cache in the JS this You are right that the website will cache the library, I'm just concerned that my system users will need to reach the external site that executes the JS code on their browsers. I'm just trying to minimize the potential risks. |
There is more information about potential risks: |
There is a new anecdotic proof that including JS from other services could lead to some security threats. |
Hey!
I noticed that each time I generate an STP file preview, the occt-import-js dependency is fetched from the CDN:
Which is changed here:
5f05ad5#diff-10ce331dec07905c5bdf64cc83d98b2892c57ac7e13312e5dae82057e64cbc65R115
What is the reason that it's not embedded anymore? Why can't it be a regular dependency?
Is there something that prevents to at least cache the result?
Idk if that's a safe thing to fetch the JS on the fly from the external sources, it's not performant either.
I could try to work on that, but I lack some context here.
Cheers.
The text was updated successfully, but these errors were encountered: