Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete players on mobile #18

Open
krazkidd opened this issue Oct 9, 2023 · 0 comments
Open

Can't delete players on mobile #18

krazkidd opened this issue Oct 9, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Merged pull requests that resolve this issue will be labeled with "hacktoberfest-accepted"

Comments

@krazkidd
Copy link
Owner

krazkidd commented Oct 9, 2023

  1. Navigate to /lineup/lineup.
  2. Add a player.
  3. Select the player <div> element so that it is focused/highlighted.
  4. ???

On desktop, you delete a player by pressing backspace in step 4. This is not possible on mobile without somehow manually pulling up the keyboard.


This can be fixed in a couple of ways, either:

a. Use long press event to trigger a prompt.
b. Delete the player if the user has the name input field focused and they press backspace when the field is empty. (This should ideally also trigger a prompt but a new issue can be created for that.)

If a prompt is added, it should be a PrimeVue dialog encapsulated in an SFC.

@krazkidd krazkidd added bug Something isn't working good first issue Good for newcomers hacktoberfest Merged pull requests that resolve this issue will be labeled with "hacktoberfest-accepted" labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Merged pull requests that resolve this issue will be labeled with "hacktoberfest-accepted"
Projects
None yet
Development

No branches or pull requests

1 participant