Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.

During caching, the --num-variations argument is broken #32

Open
JoanCharmant opened this issue Jul 23, 2021 · 0 comments
Open

During caching, the --num-variations argument is broken #32

JoanCharmant opened this issue Jul 23, 2021 · 0 comments

Comments

@JoanCharmant
Copy link

JoanCharmant commented Jul 23, 2021

for j in range(args.num_variations):

The caching code does loop num-variations times to sample rays from the source images, but it saves the current ray batch into the same file from within the loop, overwriting the file each time. So in the end the cache of each source file only contains the last variation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant