Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Forgot Password and Reset Password Flow #639

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gaurav-jo1
Copy link
Contributor

What does this PR do?

This pull request implements the full password recovery process

What issues does this PR fix or reference?

#411

If this PR changes the UI, include a screenshot below.

Untitled.design.mp4

Additional Notes:

  • The /forgot-password endpoint response does not disclose whether the email exists in the system, preventing potential enumeration attacks.

  • Added the remove_existing_token_for_email function to ensure that if a user makes multiple reset password requests, any previous tokens are invalidated.

Please let me know if there are any changes you’d like to make.

@ivntsng ivntsng assigned ivntsng and gaurav-jo1 and unassigned ivntsng Nov 24, 2024
@gaurav-jo1
Copy link
Contributor Author

Hi @ivntsng ,
It seems the test is failing, but it doesn’t appear related to the changes in this pull request. Could you please take a look?

Thanks!

@ivntsng
Copy link
Member

ivntsng commented Nov 26, 2024

Hi @ivntsng , It seems the test is failing, but it doesn’t appear related to the changes in this pull request. Could you please take a look?

Thanks!

Hello @gaurav-jo1, thanks for your contribution! I'll investigate the issue and get back to you shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants