Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTFS: Remove static module dependencies #456

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Dec 14, 2024

TL;DR

Removed GTFS static module dependencies and references from the trip planner feature

What changed?

  • Removed GTFS static module dependency from compose app and trip planner UI build files
  • Removed GTFS module and file storage module from app's Koin configuration
  • Removed NswGtfsService dependency from SavedTripsViewModel

How to test?

  1. Build and run the app
  2. Navigate to the saved trips screen
  3. Verify that saved trips functionality continues to work as expected
  4. Ensure no build errors occur due to missing GTFS dependencies

Why make this change?

The GTFS static module was no longer being utilized in the trip planner feature, making it an unnecessary dependency. Removing it helps reduce the app's complexity and build dependencies while maintaining all existing functionality.

Copy link
Owner Author

ksharma-xyz commented Dec 14, 2024

@ksharma-xyz ksharma-xyz changed the title Remove gtfs_Static dependency, unless it is ready to use GTFS: Remove static module dependencies Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant