Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicks when scrolling down #38

Closed
Devofure opened this issue Jan 9, 2015 · 9 comments
Closed

clicks when scrolling down #38

Devofure opened this issue Jan 9, 2015 · 9 comments

Comments

@Devofure
Copy link

Devofure commented Jan 9, 2015

Hi,
thank you for all your beautiful examples.

There is a bug that is annoying, in some listview examples when the user is on the topp of the list and is trying to scroll up(swiping down) then the item the user first touch is clicked or if the user scrolls up (swiping down) and holds then the onItemLongClick will be call for the fitrst touched item. So it is too easy to click on item when the user only swipes down at the top of the list.
The problem can be found at ToolbarControlListviewActivity

I hope I'm being clear about the problem :)

And another bug i found is when you scroll up and down fast then the toolbar/sticky toolbar gets stuck and you are able to see and click at the padding views at the top of the list.

so both problems can be found at the same example, ToolbarControlListviewActivity with sticky view.

@ksoichiro
Copy link
Owner

Hi,
thank you for your feedback.

About the first one, do you mean that onClick event is fired on swiping?
I don't know what version of Android you're using,
but suppose you're using Lollipop, normal list item background has ripple effect on down event(ACTION_DOWN), and it does not mean onClick is fired.

And the second one, I understand. I'll check that later.

@Devofure
Copy link
Author

Devofure commented Jan 9, 2015

Well the bug is really easy to find in Samsung s4 version 4.4.2, it happens almost every time, but in the samsung s2 version 4.1.2 and note pro 12 the bug appears only sometimes.

Well it is the OnItemClickedListener that is fired on swiping down at top of the listview or on holding at the end of the swipe the onItemLongClicked will be trigged.

@ksoichiro
Copy link
Owner

Thank you for your information.
I fixed the issues.
One of the issue was inside the library,
so if you want to try it in your own app, use "1.5.0-SNAPSHOT":

repositories {
    mavenCentral()
    maven {
        url uri('https://oss.sonatype.org/content/repositories/snapshots/')
    }
}

dependencies {
    compile "com.github.ksoichiro:android-observablescrollview:1.5.0-SNAPSHOT"
}

@Devofure
Copy link
Author

The click problem is solved now, great job.
The padding now wokrs too but it blinks now at the top of the listview.

@ksoichiro
Copy link
Owner

Thanks for checking and sorry about the blinking. I'll fix it soon.

@ksoichiro
Copy link
Owner

Finally I fixed it.
It was a difficult problem and I slightly changed the behavior based on ViewPagerTab example.

@Devofure
Copy link
Author

Nice, thank you, it works now 👍
I appreciate your work, really nice

@masudias
Copy link

I've an action bar and there's two tabs below it. I want the action bar to hide when the listview in each tab scrolls up and show the action bar while scrolling down. I've used your library and it worked like a charm except for one issue I'm facing now. It blinks in between the action bar and the tabs while scrolling up and down. Is this issue seems familiar to you?

@davemg3
Copy link

davemg3 commented Dec 14, 2018

Similar issue with #285
Do you have any clue on how to solve this?
I spent so many days to try to solve this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants