Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palo Alto driver strip_command method is not doing a strip() call #3543

Open
ktbyers opened this issue Dec 9, 2024 · 1 comment
Open

Palo Alto driver strip_command method is not doing a strip() call #3543

ktbyers opened this issue Dec 9, 2024 · 1 comment
Labels

Comments

@ktbyers
Copy link
Owner

ktbyers commented Dec 9, 2024

This calls breakage for PA and telnet since might be \r\n and not just \n.

Should just get rid of the strip_command method from the driver and revert back to base_connection.py method (i.e. I can't see any reason to override the default method here).

@ktbyers ktbyers added the bug label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants
@ktbyers and others