Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSearch ClusterOutput config docs contain apparently outdated reference to ssl_version option #107

Open
catherineluse opened this issue Nov 22, 2022 · 1 comment

Comments

@catherineluse
Copy link
Contributor

The YAML example at the top of this page https://banzaicloud.com/docs/one-eye/logging-operator/configuration/plugins/outputs/opensearch/ shows a ssl_version option being configured. However, when a ClusterOutput is created as YAML using that option, the change is not saved.

Weirdly, there seems to be a description of the ssl_version option next to an unrelated option, remove_keys_on_update:

If you want to configure SSL/TLS version, you can specify ssl_version parameter. [SSLv23, TLSv1, TLSv1_1, TLSv1_2] Remove keys on update will not update the configured keys in OpenSearch when a record is being updated. This setting only has any effect if the write operation is update or upsert.

I'm guessing what happened is that the version option was removed and the docs have yet to reflect this.

@fekete-robert
Copy link
Collaborator

Thanks for the report, from the git history of the related logging operator source file (https://github.com/banzaicloud/logging-operator/blob/master/pkg/sdk/logging/model/output/opensearch.go) it seems to me that the option was never added, either accidentally (making this a software bug) or intentionally (doc bug). @ahma : What is the solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants