Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for linux-ppc64le in CI #487

Closed
Tracked by #507
adilhusain-s opened this issue Dec 28, 2022 · 12 comments
Closed
Tracked by #507

adding support for linux-ppc64le in CI #487

adilhusain-s opened this issue Dec 28, 2022 · 12 comments

Comments

@adilhusain-s
Copy link
Contributor

adilhusain-s commented Dec 28, 2022

Hi there,
I want to add support for linux-ppc64le in CI (github action) to release binaries/docker images.
the roadmap.md file mention that CICD needs to be implemented to release the docker image.
is this roadmap.md file UpToDate?
if yes, then what github action do we want to use to implement the release process?

I suggest using the goreleaser github action.
I also want to understand how we're currently releasing the docker image for mpi-operator because I couldn't find any github workflow that does this.

let's discuss this in the comments.

@terrytangyuan
Copy link
Member

I am unsure if we should invest more time in the CI of this repo since new development will happen in the training-operator repo.

@adilhusain-s
Copy link
Contributor Author

@terrytangyuan
are we planning to archive this repo and move the development of mpi-operator to training-operator repo?
just want to understand what's the plan.

@terrytangyuan
Copy link
Member

v1 has been migrated but v2 is still under discussion.

@adilhusain-s
Copy link
Contributor Author

@terrytangyuan
Could you please provide the issue link to track v2 progress?

@alculquicondor
Copy link
Collaborator

kubeflow/training-operator#1479

tl;dr there is some desire to do it, but also some desire to keep the repos separate so that it's simpler for users to deploy.

I think it's worth adding the CI for this repo.

@terrytangyuan
Copy link
Member

Feel free to submit PRs if you'd like to help set this up.

@lehrig
Copy link

lehrig commented Jan 4, 2023

@adilhusain-s, we already enabled ppc64le CI for the training operator in kubeflow/training-operator#1692, right?

@terrytangyuan that will mean that if kubeflow/training-operator#1479 is fixed, it should also maintain ppc64le support, right?

I think we should still submit PRs here for these reasons:

(note: please find the ppc64le umbrella issue here: kubeflow/community#781)

@terrytangyuan
Copy link
Member

@terrytangyuan that will mean that if kubeflow/training-operator#1479 is fixed, it should also maintain ppc64le support, right?

Yes

@adilhusain-s
Copy link
Contributor Author

@alculquicondor @terrytangyuan
Raised PR to build and push multi-arch docker image for mpi-operator
PR link

@terrytangyuan
Copy link
Member

This seems working now. Thank you! We also need to push latest tag. Would you like to send a PR as well?

@adilhusain-s
Copy link
Contributor Author

adilhusain-s commented Jan 6, 2023

@terrytangyuan
the current workflow uses latest git tag "v0.3.0" as "latest, 0.3.0" docker tags.

if we push the git tag 'v0.4.0', there'll be docker image released with '0.4.0' and 'latest' tags.

could you specified the requirements?

docker meta action
please see the second table in above link to understand this.

@terrytangyuan
Copy link
Member

Please ignore my comment. Apparently latest tags have different meanings in different projects. :-)

@tenzen-y tenzen-y mentioned this issue Feb 17, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants