Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] <Image gcr.io/ml-pipeline/workflow-controller:v3.3.8-license-compliance is not supported for linux/arm64 paltform> #10856

Closed
Monokaix opened this issue May 30, 2024 · 5 comments
Labels
area/backend kind/bug lifecycle/stale The issue / pull request is stale, any activities remove this label.

Comments

@Monokaix
Copy link

Environment

  • How did you deploy Kubeflow Pipelines (KFP)?

while ! kustomize build example | kubectl apply -f -; do echo "Retrying to apply resources"; sleep 10; done

  • KFP version:

v1.8.0

  • KFP SDK version:

Steps to reproduce

1、execute while ! kustomize build example | kubectl apply -f -; do echo "Retrying to apply resources"; sleep 10; done
2、 failed to run image gcr.io/ml-pipeline/workflow-controller:v3.3.8-license-compliance , it show exec format error

Expected result

gcr.io/ml-pipeline/workflow-controller:v3.3.8-license-compliance run successfully

Materials and Reference


Impacted by this bug? Give it a 👍.

@Monokaix
Copy link
Author

Is there any plan to build this image on linux/arm platform?

@chensun
Copy link
Member

chensun commented May 30, 2024

workflow-controller is based on Argo's image and we only add licenses info to it:

FROM docker.io/argoproj/workflow-controller:${TAG}

You'll need to raise the ARM support request to https://github.com/argoproj/argo-workflows

@AndersBennedsgaard
Copy link

AndersBennedsgaard commented Jun 17, 2024

@chensun Argo Workflows build their images for arm (see https://github.com/argoproj/argo-workflows/blob/669d4a4e986b359dde3cd07e5616be8f713fe23d/.github/workflows/release.yaml), but the custom image created for KFP (https://github.com/kubeflow/pipelines/blob/609c637811e46eab2d5c9a915913a1520c979a88/third_party/argo/Dockerfile.workflow-controller) is built on default x86-based GH runners, so the custom image does not support arm64. If we want to create an image which supports both x86 and arm64, then we would need to change the pipeline to support this.

@Monokaix you could just use the official Argo Workflows container instead of the one built for KFP, but you will probably hit other problems when you have gotten that up and running. I for example run a cluster with a full installation of KFP v2 using the upstream Argo Workflows image, but it also takes building all KFP images outselves, as mentioned in #10309.

We might want to close this issue in favor of #10309 and add gcr.io/ml-pipeline/workflow-controller to the list of images that needs arm64-support

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Aug 17, 2024
Copy link

github-actions bot commented Sep 8, 2024

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend kind/bug lifecycle/stale The issue / pull request is stale, any activities remove this label.
Projects
None yet
Development

No branches or pull requests

3 participants