Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zw0610 from approvers #2343

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

zw0610
Copy link
Member

@zw0610 zw0610 commented Dec 2, 2024

I am removing myself from training-operator approvers.
Thanks for @kubeflow community and all your helps! @gaocegege @Jeffwan

@zw0610 zw0610 changed the title remove zw0610 from approvers Remove zw0610 from approvers Dec 2, 2024
@coveralls
Copy link

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 12132136084

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12088918617: 0.0%
Covered Lines: 77
Relevant Lines: 77

💛 - Coveralls

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of your great contributions @zw0610. I hope you will return to the project in the future!

@kubeflow/wg-training-leads What do you think about adding the emeritus_approvers section for Training Operator ?

I know that other Kubernetes projects, like Kueue, does this: https://github.com/kubernetes-sigs/kueue/blob/main/OWNERS#L16.

@gaocegege
Copy link
Member

SGTM! @zw0610 Could you please help add the emeritus_approvers in the file?

@zw0610
Copy link
Member Author

zw0610 commented Dec 3, 2024

SGTM! @zw0610 Could you please help add the emeritus_approvers in the file?

done.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions so far!

@terrytangyuan
Copy link
Member

terrytangyuan commented Dec 3, 2024

Yes we should add emeritus_approvers.

@gaocegege
Copy link
Member

/lgtm

Thanks for your contribution! 🎉 👍

@tenzen-y
Copy link
Member

tenzen-y commented Dec 3, 2024

Thanks for all of your great contributions @zw0610. I hope you will return to the project in the future!

@kubeflow/wg-training-leads What do you think about adding the emeritus_approvers section for Training Operator ?

I know that other Kubernetes projects, like Kueue, does this: https://github.com/kubernetes-sigs/kueue/blob/main/OWNERS#L16.

SGTM
Additionally, I would propose the mention emeritus_approvers to the kubefolow governance.

@tenzen-y
Copy link
Member

tenzen-y commented Dec 3, 2024

@zw0610 Thank you for all your contributions! I hope you are well on your next journey!

@tenzen-y
Copy link
Member

tenzen-y commented Dec 3, 2024

/approve
/hold for a while

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

andreyvelich commented Dec 3, 2024

@tenzen-y Do you mean mention it somewhere here: https://www.kubeflow.org/docs/about/membership/#inactive-members ?

@tenzen-y
Copy link
Member

tenzen-y commented Dec 4, 2024

@tenzen-y Do you mean mention it somewhere here: https://www.kubeflow.org/docs/about/membership/#inactive-members ?

I would indicate https://www.kubeflow.org/docs/about/membership/#approver

@andreyvelich
Copy link
Member

I think, we should be ready to merge it.
/hold cancel

@google-oss-prow google-oss-prow bot merged commit 265d4c7 into kubeflow:master Dec 4, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants