Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposals for new maintainers and reviewers #1078

Closed
mdbooth opened this issue Dec 8, 2021 · 8 comments · Fixed by #1083
Closed

Proposals for new maintainers and reviewers #1078

mdbooth opened this issue Dec 8, 2021 · 8 comments · Fixed by #1083

Comments

@mdbooth
Copy link
Contributor

mdbooth commented Dec 8, 2021

As we've got a fair bit going on at the moment, I wonder if we should consider adding to the reviewer pool. Purely to start the discussion, how would we feel about the following additions?

Maintainer

Reviewer

This is a straw man from the top of my head! My apologies if I missed anybody obvious 😬

/cc @jichenjc @hidekazuna

@hidekazuna
Copy link
Contributor

I agree we need more maintainer who can add /approve.

/cc @chrischdi @seanschneeweiss

@seanschneeweiss
Copy link
Contributor

I'd suggest @tobiasgiese and @mdbooth
as a maintainer too. Other than that, really happy to help as a maintainer.

@chrischdi
Copy link
Member

chrischdi commented Dec 9, 2021

I'd also be happy to help :-) I also plan to get more time to do upstream work for next year 👍

@macaptain
Copy link
Contributor

I also +1 @mdbooth as maintainer given the amount and quality of activity on the project over the last year.

For my part, I'd be happy to take on doing more reviews more regularly in CAPO as a reviewer.

@hidekazuna
Copy link
Contributor

+1 for @tobiasgiese and @mdbooth

@tobiasgiese worked on issues like Provide documentation website (like CAPA/CAPZ)(#783), and Change default branch to "main"(#855) as practical maintainer.
@mdbooth contributes many functionalities with high quality.

@tobiasgiese
Copy link
Member

tobiasgiese commented Dec 9, 2021

@tobiasgiese worked on issues like Provide documentation website (like CAPA/CAPZ)(#783), and Change default branch to "main"(#855) as practical maintainer.

Just to clarify, I also worked on other issues except for documentation and branch renaming 😅 (xref)

And thanks for the suggestion 🙂

@mdbooth
Copy link
Contributor Author

mdbooth commented Dec 9, 2021

I would also be happy to help out as a maintainer, although I will say that there are changes that I wouldn't yet feel confident to approve myself. It's good to have a broad team!

@tobiasgiese
Copy link
Member

And thanks for the suggestion

And I'm also happy to help as a maintainer, for sure! I forgot to mention that 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants