cleanup: remove vendoring #834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: binacs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
4 tasks
|
cc @Huang-Wei PTAL, thanks! |
Huang-Wei
reviewed
Nov 24, 2024
There was a problem hiding this comment.
Thank you so much, @binacs!
Could you please help with the following?
- Split the PR into two commits:
- One commit for the code changes only
- Another commit for the removal of the
vendor/directory
- Update
hack/update-codegen.sh:
- Ensure the script runs successfully and generates no differences in the current codebase
- Test it by making some mock changes (e.g., removing some API fields) and verify that it produces the expected output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #760
Special notes for your reviewer:
Does this PR introduce a user-facing change?