-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to new default branch name #50
Comments
+1 from github management team hat on |
I've been updating description as I go. Dropped TODO's on what remains. I'm going to try and update k/community docs before closing this out. I'll post further updates as comments, not just description edits |
Opened kubernetes/community#5687 and kubernetes/test-infra#21617 to close out the actual rename part of this, leaving notification, and then updating the branch rename docs as a followup |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
/close No remaining references to the old branch: https://cs.k8s.io/?q=slack-infra.*master&i=nope&files=&excludeFiles=&repos= |
@spiffxp: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Part of umbrella issue to rename default branches: kubernetes/org#2222
Copy-pasted checklist from https://raw.githubusercontent.com/kubernetes/community/master/github-management/default-branch-migration.md
Changes pre-rename
Make the following changes before renaming the branch the
master
branch.Note: There might be additional changes required that have not been
covered in this checklist.
Anytime
These changes are non-disruptive and can be made anytime before
renaming the branch.
If a prowjob triggers on the
master
branch (branches
fieldof the prowjob), add the
main
branch to the list(see [prep kubernetes/org jobs for default branch rename kubernetes/test-infra#20665] for an example).
If the [
milestone_applier
] prow config references themaster
branch,add the
main
branch to the config (see [Prep kubernetes/k8s.io for default branch rename kubernetes/test-infra#20675] for an example).If the [
branch_protection
] prow config references themaster
branch,add the
main
branch to the config.Just before rename
These changes are disruptive and should be made just before
renaming the branch.
If a prowjob mentions the
master
branch inbase_ref
,update it to the
main
branch. For a periodic job, ensure thatthe branch is renamed between periodic job runs.
If a prowjob mentions
master
in its name, rename the job toto not include the branch name. [
status-reconciler
] should automaticallymigrate the PR status contexts to the new job name but this has not been tested yet.
The job with the new name will also appear as a differt job in Testgrid.
If a prowjob calls scripts or code in your repo that explicitly
reference
master
, update all references to usemain
.If the repo has netlify configured for it, ask a member of the GitHub
Management Team to rename the
master
branch tomain
in the netlify site config.It can't be controlled through the netlify config in the repo.
Approval
have been identified, assign the GitHub Management team ([@kubernetes/owners])
for approval.
Rename the default branch
master
tomain
using the GitHub UIby following the [official instructions].
Changes post-rename
After the default branch has been renamed to
main
, make the followingchanges.
Note: There might be additional changes required that have not been
covered in this checklist.
Prowjobs
master
branch in thebranches
field,remove the
master
branch (see [Update kubernetes/org job configs post default-branch-rename kubernetes/test-infra#20669] for an example).Prow config
If the [
milestone_applier
] prow config references themaster
branch,remove it from the config.
If the [
branch_protection
] prow config references themaster
branch,remove it from the config.
Other
If any docs reference the
master
branch, update tomain
(URLs will be automatically redirected).
Ensure that CI and PR tests work fine.
Trial the local development experience with a pre-rename clone.
Send a notice about the branch rename to your SIG's mailing list.
Include the link to the [GitHub instructions to rename your local branch].
/assign
/sig contributor-experience
/kind cleanup
The text was updated successfully, but these errors were encountered: