Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Staging images away from GCR to AR #12400

Open
ameukam opened this issue Nov 21, 2024 · 11 comments
Open

Migrate Staging images away from GCR to AR #12400

ameukam opened this issue Nov 21, 2024 · 11 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@ameukam
Copy link
Member

ameukam commented Nov 21, 2024

What do you want to happen?

Publish images to a new AR container repository. GCR is depecrated and will be removed on March 2025:
https://cloud.google.com/artifact-registry/docs/transition/prepare-gcr-shutdown#what-happens-after-shutdown

Is there currently another issue associated with this?

@ameukam ameukam added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 21, 2024
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Nov 21, 2024
@ameukam
Copy link
Member Author

ameukam commented Nov 21, 2024

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 21, 2024
@ameukam
Copy link
Member Author

ameukam commented Nov 21, 2024

FYI @kubernetes/ingress-nginx-maintainers

@Gacko Gacko self-assigned this Nov 21, 2024
@longwuyuan
Copy link
Contributor

Can you help improve the description and make it more elaborate and descriptive.

Where is the connection to gcr

% k -n ingress-nginx describe po ingress-nginx-controller-699896b45d-vz42s| grep -i image
    Image:           registry.k8s.io/ingress-nginx/controller:v1.11.3@sha256:d56f135b6462cfc476447cfe564b83a45e8bb7da2774963b00d12161112270b7
    Image ID:        registry.k8s.io/ingress-nginx/controller@sha256:d56f135b6462cfc476447cfe564b83a45e8bb7da2774963b00d12161112270b7
  Normal   Pulled          26m                kubelet                   Container image "registry.k8s.io/ingress-nginx/controller:v1.11.3@sha256:d56f135b6462cfc476447cfe564b83a45e8bb7da2774963b00d12161112270b7" already present on machine

@longwuyuan
Copy link
Contributor

/remove-priority important-soon
/remove-triage accepted

can reapply labels after detailing the description of the issue

@k8s-ci-robot k8s-ci-robot added needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 21, 2024
@Gacko
Copy link
Member

Gacko commented Nov 21, 2024

We are currently pushing images to GCR. As far as I can tell registry.k8s.io is just another name for that. Before promotion images definitely get pushed to GCR.

@longwuyuan
Copy link
Contributor

So these 23 locations for gcr.io will change to something like pkg.dev https://github.com/search?q=repo%3Akubernetes%2Fingress-nginx%20%20gcr.io&type=code

And similarly all code instance for registry.k8s.io will also change to registry-k8s.pkg.dev

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Nov 22, 2024
@Gacko
Copy link
Member

Gacko commented Nov 22, 2024

@ameukam Right now we're publishing images to GCR via Google Cloud Build. In there is a part responsible for the authentication to Google Cloud // Container Registry.

Do I understand correctly that this authentication stays the same and we can just change all the occurrences of GCR to AR in the pushing part and then step by step replace pulling from GCR by AR with the new images as the old images will still exist in GCR?

@ameukam
Copy link
Member Author

ameukam commented Nov 22, 2024

@Gacko theoretically, the authentication should stay the same for AR. The images hosted on old images will be copied over the AR repository.

@Gacko
Copy link
Member

Gacko commented Nov 22, 2024

Alright, thank you! I just also read the issue you linked and docs linked in there. If I get everything correctly, this is only affecting the staging registry, so registry.k8s.io and everything referencing it stays the same, right?

@ameukam
Copy link
Member Author

ameukam commented Nov 22, 2024

Yes. There is no changes for registry.k8s.io since it's already backed by AR. The migration is only focused on the staging repositories.

@strongjz strongjz added this to the release-1.13 milestone Nov 24, 2024
@strongjz strongjz self-assigned this Nov 24, 2024
@strongjz
Copy link
Member

@Gacko you have a lot already on your plate, i'll go ahead and take this one.

@strongjz strongjz changed the title Migrate away from GCR to AR Migrate Staging images away from GCR to AR Nov 24, 2024
ameukam added a commit to ameukam/k8s.io that referenced this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

No branches or pull requests

5 participants