Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the O Series #262

Open
fabiand opened this issue Oct 29, 2024 · 3 comments
Open

Remove the O Series #262

fabiand opened this issue Oct 29, 2024 · 3 comments
Labels

Comments

@fabiand
Copy link
Member

fabiand commented Oct 29, 2024

What happened:
There is low value n the O Series. Let's remove it.
KubeVirt gained memory overcommit, an admin sided feature, that's easier and more consistent to use.

What you expected to happen:
A clear and concise description of what you expected to happen.

How to reproduce it (as minimally and precisely as possible):
Steps to reproduce the behavior.

Additional context:
Add any other context about the problem here.

Environment:

  • KubeVirt version (use virtctl version): N/A
  • Kubernetes version (use kubectl version): N/A
  • VM or VMI specifications: N/A
  • Cloud provider or hardware configuration: N/A
  • OS (e.g. from /etc/os-release): N/A
  • Kernel (e.g. uname -a): N/A
  • Install tools: N/A
  • Others: N/A
@lyarwood
Copy link
Member

@fabiand I believe that support pre-dates the work @vladikr did in kubevirt/kubevirt#9799 that is used by this instance type class. I'm not against removing it I just wanted to check with you both that we still want to deprecate this as I'll also remove support from the instancetype.kubevirt.io API.

@fabiand
Copy link
Member Author

fabiand commented Oct 29, 2024

I would remove the O Series.

But I do not understand remove support from the instancetype.kubevirt.io API. could you rephrase this for me?

Also: We might want to add the "graduation level" to instanceTypes

@lyarwood
Copy link
Member

I would remove the O Series.

But I do not understand remove support from the instancetype.kubevirt.io API. could you rephrase this for me?

kubevirt/kubevirt#9799 specifically introduced the spec.memory.overcommitPercent attribute used by this class. If it's no longer used here I was going to deprecate it in v1beta1 to potentially drop ahead of v1 in the future.

Also: We might want to add the "graduation level" to instanceTypes

Possibly, we could definitely use it for preferences for non-GA'd OS's etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants