Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Reduce the usage of unwrap() #26

Open
kud1ing opened this issue Nov 22, 2017 · 0 comments
Open

Reduce the usage of unwrap() #26

kud1ing opened this issue Nov 22, 2017 · 0 comments

Comments

@kud1ing
Copy link
Owner

kud1ing commented Nov 22, 2017

We use unwrap() in some places where the result should "in theory" always be existant.

We should handle those unlikely cases. Consider:

  • bubble Nones up in functions that return an Option. Consider using ? for Options in Rust 1.22.
  • panic if JVM methods fail when we can not handle it otherwise
@kud1ing kud1ing changed the title Remove the usage of unwrap() Reduce the usage of unwrap() Nov 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant