You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there. Nice work on compacting and encapsulating the Timeline control. I had some minor issues with it that I'd like to share:
When I initially added the timeline folder into my Rails application, it failed because of inclusion of files had out-of-order references to classes defined in other files. These are the changes I had to do:
ajax/ becomes control.ajax/ # It needs to come after base files, and before timeline/ext folder
baseline.js to base.line.js # It needs to come before base.timeline.js
platform.js to base.platform.js # Ajax folder files reference it
base.timeline.js to fn.timeline.js # Needs to come after date-time.js amd before labelers.js
There was an issue with a couple of the label.js files in timeline/lion/ subfolders having invalid UTF-8 sequences. I had to use my editor (Sublime Editor 2) to do an explicit save with encoding to fix these files.
In base.timeline.js, at the end of the window.Timeline definition, I had to add a comma, and the following line:
SortedArray: SimileAjax.SortedArray
This is because the ext/japanese-eras.js refers to Timeline.SortedArray, which was never defined, but it's a good bet that it's the same as the other SortedArray, and since I'm not using Japanese text it may be a moot point anyway.
In the band.js file onclick handler, I needed to add a similar line as in the doubleclick handler to use:
var element = event.srcElement ? event.srcElement : event.target;
and use the resulting element in the following lines rather than event.srcElement
In band.js, I had to rename two occurances of <div classname= with <div class=
for vertical scrolling to work properly
The text was updated successfully, but these errors were encountered:
A very useful fix list, all of which I needed also. For (3) above I simply removed the japanese stuff as I don't need it, which fixed the issue with SortedArray.
Hi there. Nice work on compacting and encapsulating the Timeline control. I had some minor issues with it that I'd like to share:
There was an issue with a couple of the label.js files in timeline/lion/ subfolders having invalid UTF-8 sequences. I had to use my editor (Sublime Editor 2) to do an explicit save with encoding to fix these files.
In base.timeline.js, at the end of the window.Timeline definition, I had to add a comma, and the following line:
SortedArray: SimileAjax.SortedArray
This is because the ext/japanese-eras.js refers to Timeline.SortedArray, which was never defined, but it's a good bet that it's the same as the other SortedArray, and since I'm not using Japanese text it may be a moot point anyway.
In the band.js file onclick handler, I needed to add a similar line as in the doubleclick handler to use:
var element = event.srcElement ? event.srcElement : event.target;
and use the resulting element in the following lines rather than event.srcElement
In band.js, I had to rename two occurances of <div classname= with <div class=
for vertical scrolling to work properly
The text was updated successfully, but these errors were encountered: