Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of small fixes #5

Open
PaulGilbert opened this issue Dec 12, 2013 · 2 comments
Open

List of small fixes #5

PaulGilbert opened this issue Dec 12, 2013 · 2 comments

Comments

@PaulGilbert
Copy link

Hi there. Nice work on compacting and encapsulating the Timeline control. I had some minor issues with it that I'd like to share:

  1. When I initially added the timeline folder into my Rails application, it failed because of inclusion of files had out-of-order references to classes defined in other files. These are the changes I had to do:
  • ajax/ becomes control.ajax/ # It needs to come after base files, and before timeline/ext folder
  • baseline.js to base.line.js # It needs to come before base.timeline.js
  • platform.js to base.platform.js # Ajax folder files reference it
  • base.timeline.js to fn.timeline.js # Needs to come after date-time.js amd before labelers.js
  1. There was an issue with a couple of the label.js files in timeline/lion/ subfolders having invalid UTF-8 sequences. I had to use my editor (Sublime Editor 2) to do an explicit save with encoding to fix these files.

  2. In base.timeline.js, at the end of the window.Timeline definition, I had to add a comma, and the following line:
    SortedArray: SimileAjax.SortedArray

    This is because the ext/japanese-eras.js refers to Timeline.SortedArray, which was never defined, but it's a good bet that it's the same as the other SortedArray, and since I'm not using Japanese text it may be a moot point anyway.

  3. In the band.js file onclick handler, I needed to add a similar line as in the doubleclick handler to use:
    var element = event.srcElement ? event.srcElement : event.target;
    and use the resulting element in the following lines rather than event.srcElement

  4. In band.js, I had to rename two occurances of <div classname= with <div class=
    for vertical scrolling to work properly

@PaulGilbert
Copy link
Author

Another issue: in overview-painter.js, the line starting with:
var tapeDiv = $("div
should read:
var tapeDiv = $("<div

Without this fix, overview bands won't render.

@philwig
Copy link

philwig commented Apr 11, 2016

A very useful fix list, all of which I needed also. For (3) above I simply removed the japanese stuff as I don't need it, which fixed the issue with SortedArray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants