Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROADMAP v1.0 #8

Open
4 of 10 tasks
kybarg opened this issue Nov 21, 2019 · 12 comments
Open
4 of 10 tasks

ROADMAP v1.0 #8

kybarg opened this issue Nov 21, 2019 · 12 comments

Comments

@kybarg
Copy link
Owner

kybarg commented Nov 21, 2019

This modules popularity is growing, and while currently it satisfies need of my use case, I can see that some people struggle to integrate this into their project. So I want to define goals for V1, where everyone could be happy😊
Work can be tracked at next branch

Progress

@kybarg kybarg pinned this issue Nov 21, 2019
@kybarg kybarg changed the title ROADMAP ROADMAP v1 Nov 21, 2019
@kybarg kybarg changed the title ROADMAP v1 ROADMAP v1.0 Nov 21, 2019
@Indigo744
Copy link

Hello

It would be good to add more documentation:

  • why iOS should use legacymode, how to handle it with code
  • CSP (Content Security Policy) header needs to allow Blob WebWorkers (worker-src blob:)
  • FP (Feature Policy) header needs to allow camera (camera 'self')

Thank you.

@Indigo744
Copy link

May I suggest a few more things?

  1. Add TypeScript typing
  2. Add an enabled boolean option which allow to easily enable/disable image processing

I am willing to help if needed. Let me know.

@jaysella
Copy link

jaysella commented Apr 25, 2020

@kybarg Has any progress been made on adding an enabled boolean?

@alagiz
Copy link

alagiz commented Sep 19, 2020

is the project abandoned?

@pedropalhari
Copy link
Contributor

As this lib is relatively simple and I like it a lot, I'll be contributing on the roadmap to the v1.0

I just ask patience because I'm relatively new on contributing to libs, so I may code the features on a non-orderly manner

pedropalhari added a commit to pedropalhari/react-qr-scanner that referenced this issue Sep 23, 2020
pedropalhari added a commit to pedropalhari/react-qr-scanner that referenced this issue Sep 24, 2020
…y typescript and on the README at 24/09/2020. (fix kybarg#32) (kybarg#8)
@pedropalhari
Copy link
Contributor

Just quick ping on @kybarg, is it okay if I use this repo as an issue/feature tracker? If so, could you enable labels to the issues?

kybarg pushed a commit that referenced this issue Sep 25, 2020
* Initial type adding, mapping current structures and adding props

* Finishing typing, based on the props and types currently identified by typescript and on the README at 24/09/2020. (fix #32) (#8)
@rdelrioge
Copy link

Hi @pedropalhari I was looking your updates on your new repo, I was wondering, could you update the legacy-mode example with hooks too please? I'm kind of lost with this library.

@pedropalhari
Copy link
Contributor

Hi @pedropalhari I was looking your updates on your new repo, I was wondering, could you update the legacy-mode example with hooks too please? I'm kind of lost with this library.

Hi @rdelrioge! I updated the hooks but it wasn't accepted, you can check it out on this commit from this pull request!
8944be9

I think it's not up to the requirements of the repo owner yet, but I haven't received feedback so feel free to use it as is for now.

@kybarg
Copy link
Owner Author

kybarg commented Dec 9, 2020

@pedropalhari @rdelrioge Sorry, don't have much time lately. Started refactoring on next branch . So please check it out. Leagacy mode is still in development. I see it as separate component, and then have component which will include normal and legacy mode. In that case both gonna be standalone components which is good for customization for the needs of your projects.

@pedropalhari
Copy link
Contributor

@kybarg wonderful! This repo is a service to the community, no need to apologize. If you need something you can ping me up anytime.

@rdelrioge
Copy link

Hi @pedropalhari @kybarg I think I made it work with hooks with this code

import React, { useState, useRef } from "react"
import QrReader from "react-qr-reader"

function Reader() {

const reader = useRef(null);
const [code, setCode] = useState("");

const handleScan = (data) => {
	setCode(data);
};

const handleError = (err) => {
	console.error(err);
};

const openImageDialog = () => {
	reader.current.openImageDialog();
};

return (
	<div>
		<QrReader
			ref={reader}
			onError={handleError}
			onScan={handleScan}
			legacyMode
		/>
		<button onClick={openImageDialog}>Sumbit a QR Code</button>
		<p>{code}</p>
	</div>
);
}

export default Reader;

@FedeBev
Copy link

FedeBev commented Apr 21, 2021

Do you plan a typescript migration for typing support? Or just a .d.ts file?
I could deal with a typescript migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants