Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend the .nkg file to have LH and RH vertex numbers #141

Closed
4 tasks
neukym opened this issue Jan 27, 2024 · 3 comments · Fixed by #146
Closed
4 tasks

Amend the .nkg file to have LH and RH vertex numbers #141

neukym opened this issue Jan 27, 2024 · 3 comments · Fixed by #146
Assignees
Labels
🪲 bug Something isn't working gridsearch Related to the gridsearch 📄 .nkg files

Comments

@neukym
Copy link
Member

neukym commented Jan 27, 2024

As a result of #140, we need to add in different hexel numbers for both LH and RH.

Note that these
a) needn't be the same size
b) needn't have the same vertex numbers.

@neukym
Copy link
Member Author

neukym commented Jan 27, 2024

in particular, `gridsearch/plain.py'

            hexels=channel_names[1,:10239], # TODO: HACK - FIX WITH ISSUE #141
            data_lh=log_pvalues_lh[:10239,], # TODO: HACK - FIX WITH ISSUE #141
            data_rh=log_pvalues_rh[:10239,], # TODO: HACK - FIX WITH ISSUE #141

Should be something like:

            hexels=[channel_names[:len(log_pvalues_lh)], len(log_pvalues_lh):],
            data_lh=log_pvalues_lh,
            data_rh=log_pvalues_rh,

@neukym neukym added 🪲 bug Something isn't working gridsearch Related to the gridsearch labels Jan 27, 2024
@caiw caiw self-assigned this Jan 27, 2024
@caiw
Copy link
Member

caiw commented Jan 27, 2024

I'm happy to take this one. I will take a little bit of doing because I wrongly thought this was a logical constraint — sorry about that.

@neukym
Copy link
Member Author

neukym commented Jan 27, 2024

👍 happily this isn't a really a blocker as my above hack forces the code to trim the data by a couple of vertices so they are equal. Let's chat about priorities at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working gridsearch Related to the gridsearch 📄 .nkg files
Projects
None yet
2 participants