Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis limits are hard-coded in expression plots #15

Closed
caiw opened this issue Oct 13, 2023 · 3 comments
Closed

Axis limits are hard-coded in expression plots #15

caiw opened this issue Oct 13, 2023 · 3 comments
Labels
💪 enhancement New feature or request 📈 plotting functionality Any issues related to plotting

Comments

@caiw
Copy link
Member

caiw commented Oct 13, 2023

Should be generated from data, with optional arguments to force.

@caiw caiw added the 💪 enhancement New feature or request label Oct 13, 2023
@neukym neukym added the 📈 plotting functionality Any issues related to plotting label Oct 17, 2023
@neukym
Copy link
Member

neukym commented Oct 29, 2023

My suggestion, instead of line 43 in plotting.py

if ylim is None:
            ylim = 10 ** -100

something like (apologies for pseudocode):

if ylim is None:
        lowest_pvalue = lowest_pvalue_of_all_functions_in_show_functions_from_both_left_and_right_hemi
        if lowest_pvalue <= 10 ** -100:
            ylim = lowest_pvalue + 10 ** -10
        else:
            ylim = 10 ** -100

@neukym
Copy link
Member

neukym commented Oct 29, 2023

As an aside, @ollieparish has found the first sub- 10 ** -100 function already...

@neukym
Copy link
Member

neukym commented Nov 20, 2023

Closed with #55

@neukym neukym closed this as completed Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request 📈 plotting functionality Any issues related to plotting
Projects
None yet
Development

No branches or pull requests

2 participants