Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete variables after use to keep memory requirements down for gridsearch #314

Open
young-x-skyee opened this issue Jul 11, 2024 · 2 comments
Open

Delete variables after use to keep memory requirements down for gridsearch #314

young-x-skyee opened this issue Jul 11, 2024 · 2 comments
Assignees
@young-x-skyee
Labels
💪 enhancement New feature or request give it a go! The change to be made isn't too complex or has been described as part of the issue or discussion gridsearch Related to the gridsearch one-line-fix A very quick and simple fix of (approx) one line

Comments

@young-x-skyee
Copy link
Contributor

When the number of derangements increases, the gridsearch in source space will stop in the middle (not the first function) if we are running on multiple functions. The should not be the case if we delete the variables related to the function after completing the gridsearch on it. Not difficult to solve, but may need to increase the number of derangements to check
@young-x-skyee young-x-skyee added 💪 enhancement New feature or request give it a go! The change to be made isn't too complex or has been described as part of the issue or discussion gridsearch Related to the gridsearch one-line-fix A very quick and simple fix of (approx) one line labels Jul 11, 2024
@young-x-skyee young-x-skyee self-assigned this Jul 11, 2024
young-x-skyee added a commit that referenced this issue Jul 24, 2024
@young-x-skyee
Update plain.py
33b57f5 
Delete the variables after doing gridsearch on each function. Not sure if this totally fixes #314 since the execution time really varies.
@young-x-skyee young-x-skyee mentioned this issue Jul 24, 2024
Closed
@neukym
Copy link
Member

neukym commented Aug 4, 2024 •
edited
Loading

It's not clear why Kymata is running out of memory after testing more than one function – all of the variables inside the gridsearch should have been deleted when the gridsearch returns the results.

@neukym
Copy link
Member

neukym commented Nov 3, 2024 •
edited
Loading

To reproduce:

For source space, do the TVL family, and up the parameters to:

  • 7 derrangements and 200 Hz, or
  • 6 derangement and 250 Hz.

It should crash the third or fourth transform in (IL2 or IL3).

@neukym neukym mentioned this issue Nov 3, 2024
Open
@neukym neukym mentioned this issue Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@young-x-skyee young-x-skyee

Labels
💪 enhancement New feature or request give it a go! The change to be made isn't too complex or has been described as part of the issue or discussion gridsearch Related to the gridsearch one-line-fix A very quick and simple fix of (approx) one line
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update plain.py kymata-atlas/kymata-core
2 participants
@neukym @young-x-skyee