Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plain.py #336

Closed
wants to merge 1 commit into from
Closed

Update plain.py #336

wants to merge 1 commit into from

Conversation

young-x-skyee
Copy link
Contributor

Delete the variables after doing gridsearch on each function. Not sure if this totally fixes #314 since the execution time really varies.

Delete the variables after doing gridsearch on each function. Not sure if this totally fixes #314 since the execution time really varies.
@young-x-skyee young-x-skyee added 💪 enhancement New feature or request one-line-fix A very quick and simple fix of (approx) one line labels Jul 24, 2024
@young-x-skyee young-x-skyee requested a review from neukym July 24, 2024 11:02
Copy link
Member

@neukym neukym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks.

neukym

This comment was marked as duplicate.

Copy link
Member

@neukym neukym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually can we hold off for a second.

@neukym
Copy link
Member

neukym commented Jul 24, 2024

closing as we think it should be deleting these anyway

@neukym neukym closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request one-line-fix A very quick and simple fix of (approx) one line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete variables after use to keep memory requirements down for gridsearch
2 participants