Server::new doesn't need to be async

[HexyWitch]

There are no awaits. Is it a future proofing thing?

No big deal but I made an issue just in case. Changing it would be a breaking API change so probably not worth a major version bump on its own.

[kyren]

Oh it's not supposed to be there, it's a leftover from using tokio directly, and specifically using this method to create a UdpSocket : https://docs.rs/tokio/latest/tokio/net/struct.UdpSocket.html#method.bind

That method is async, but only because it accepts hostnames and does an optional DNS lookup on them. You can get around it by opening a std UdpSocket and then converting it to a tokio one, which is what is done in the tokio implementation of the Runtime trait now. I didn't realize why that method was async until I actually looked at it during the last refactor to being runtime agnostic with the Runtime trait.

It's just a leftover, and there hasn't even been a release since it could be removed so it should just be removed. Thank you for catching it 😔