Missing styles fix #205
Open
Missing styles fix #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jan 11, 2019
•
ghost
commented
- Channel setting's additional options and edit message retention modal style missing fix
- search modal files list missing style fix
style missing fix
houndci-bot
reviewed
Jan 11, 2019
mastermel
requested changes
Mar 4, 2019
houndci-bot
reviewed
May 27, 2019
houndci-bot
reviewed
May 27, 2019
houndci-bot
reviewed
May 29, 2019
houndci-bot
reviewed
May 29, 2019
mastermel
requested changes
May 31, 2019
There was a problem hiding this comment.
Please see my follow up comments, and also make the changes requested by the linter. Please don't simply resolve the linter's comments. It helps keep the codebase consistent to follow these suggestions. If you feel like any of the linter rules are unnecessary than please submit a separate PR with your suggested changes there.
Thanks!
houndci-bot
reviewed
Jul 12, 2019
houndci-bot
reviewed
Jul 26, 2019
houndci-bot
reviewed
Jul 26, 2019
houndci-bot
reviewed
Jul 26, 2019
houndci-bot
reviewed
Jul 29, 2019
houndci-bot
reviewed
Jul 30, 2019
houndci-bot
reviewed
Jul 30, 2019
houndci-bot
reviewed
Jul 30, 2019
houndci-bot
reviewed
Jul 30, 2019
| @@ -97,4 +99,4 @@ | |||
| @import "modules/pages/apps"; | |||
| @import "modules/pages/legal"; | |||
| @import "modules/pages/oauth"; | |||
| @import "modules/pages/spaces"; | |||
| @import "modules/pages/spaces"; | |||
There was a problem hiding this comment.
Files should end with a trailing newline
houndci-bot
reviewed
Aug 12, 2019
|
|
||
| .p-unreads_view { | ||
| background: $color-base; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.