Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nice to have: Support for patches in git submodules #42

Open
lamikr opened this issue Jun 3, 2024 · 0 comments
Open

nice to have: Support for patches in git submodules #42

lamikr opened this issue Jun 3, 2024 · 0 comments

Comments

@lamikr
Copy link
Owner

lamikr commented Jun 3, 2024

Current patch mechanism only support patches in main-projects which is one reason why aotriton project has been flattened to single repo. (aotriton)

Implementation idea based on to aotriton which has 3 git submodules located in directories

third_party/triton/
third_party/pypind11/
third_party/incbin/

Under the projects main patch dir, there could be similar sub-directory structure than in main project to easy for marking the directories where to do the patch apply. For example in the aotriton project the patches directory structure could be

patches/rocm-6.1.1/aotriton/001-aotriton-main-project_change1.patch
patches/rocm-6.1.1/aotriton/third_party/triton/change1.patch
patches/rocm-6.1.1/aotriton/third_party/triton/change2.patch
patches/rocm-6.1.1/aotriton/third_party/pypind11/change1.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant