Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zend\Ldap\Dn::isChildOf - should it be case insensitive? #4

Open
weierophinney opened this issue Dec 31, 2019 · 2 comments
Open

Zend\Ldap\Dn::isChildOf - should it be case insensitive? #4

weierophinney opened this issue Dec 31, 2019 · 2 comments

Comments

@weierophinney
Copy link
Member

This is a "reopen" of zendframework/zendframework#6299

I just ran into the same problem. The comparison in isChildOf is case sensitive in regard to the attribute values (not the attribute names which have been changed to lower case before). This is incorrect if the attribute is, for instance, of type DirectoryString using matching rule caseIgnoreMatch for equality match.

For example, we use base DN "ou=people,o=ldap". A user DN might be "uid=test,ou=People,o=ldap" (note the capital "P").

isChildOf won't match in this case, even though the user DN is of a child of the base DN. This is incorrect as the ou attribute must be checked case insensitive.

As a quick workaround I modified the line

if ($cdn[$i + $startIndex] != $pdn[$i]) {

in Dn.php to this test:

$result = array_udiff_uassoc($cdn[$i + $startIndex], $cdn[$i + $startIndex], 'strcasecmp', 'strcasecmp');
if (! empty($result) ) {

This compares attribute names and values case insensitive. Of course, this is not complete as whitespace should be removed as well and some attributes in the DN might actually be case sensitive. Thus I guess ideally, the test should be done by an ldap query instead...


Originally posted by @gvde at zendframework/zend-ldap#54

@weierophinney
Copy link
Member Author

Thanks for raising the issue! I'll have an in depth look at it later.


Originally posted by @heiglandreas at zendframework/zend-ldap#54 (comment)

@weierophinney
Copy link
Member Author

The comparison should use the schema-information for the attribute to decide whether to check case sensitive or insensitive. As that might include a severe performance-issue I'll need to check how to implement that in a way that satisfies all needs…


Originally posted by @heiglandreas at zendframework/zend-ldap#54 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant