Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RZ solver and user material model updates #225

Merged
merged 35 commits into from
Sep 6, 2024
Merged

RZ solver and user material model updates #225

merged 35 commits into from
Sep 6, 2024

Conversation

nathanielmorgan
Copy link
Collaborator

Description

updated material model coding to support user defined strength models and fixed a bug in RZ solver for strength

Type of change

Please select all relevant options

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Formatting and/or style fixes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran regression tests and ran user defined models

  • Test A : regression tests
  • Test B : Taylor impact tests

Test Configuration:

  • OS version: MacOS
  • Hardware: x86
  • Compiler: clang

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code builds from scratch with my new changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

const size_t mat_pt_lid,
static void calc_stress(const DCArrayKokkos<double>& MaterialPoints_pres,
const DCArrayKokkos<double>& MaterialPoints_stress,
const size_t MaterialPoints_lid,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this value is for a single material point, so having the s at the end making it plural is a bit confusing. I think the rest of the inputs are the data for all material points, so plural makes sense there.

Copy link
Collaborator

@jacob-moore22 jacob-moore22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few questions, looks good to me.

@nathanielmorgan nathanielmorgan merged commit 92ade59 into main Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants