-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RZ solver and user material model updates #225
Conversation
const size_t mat_pt_lid, | ||
static void calc_stress(const DCArrayKokkos<double>& MaterialPoints_pres, | ||
const DCArrayKokkos<double>& MaterialPoints_stress, | ||
const size_t MaterialPoints_lid, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this value is for a single material point, so having the s at the end making it plural is a bit confusing. I think the rest of the inputs are the data for all material points, so plural makes sense there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a few questions, looks good to me.
… ignoring data files
Merge commit
Merge commit take 2?
Description
updated material model coding to support user defined strength models and fixed a bug in RZ solver for strength
Type of change
Please select all relevant options
How Has This Been Tested?
Ran regression tests and ran user defined models
Test Configuration:
Checklist: