Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and more docs #15

Merged
merged 8 commits into from
Nov 24, 2024
Merged

Cleanup and more docs #15

merged 8 commits into from
Nov 24, 2024

Conversation

adamdempsey90
Copy link
Collaborator

@adamdempsey90 adamdempsey90 commented Nov 23, 2024 •
edited by brryan
Loading

Background

Description of Changes

Checklist

  • New features are documented
  • Tests added for bug fixes and new features
  • (@lanl.gov employees) Update copyright on changed files

brryan
brryan approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@brryan brryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the failing disk problems in CI, which I guess are related to the removal of de_switch from inputs

inputs/disk/disk_axi.in Show resolved Hide resolved
@brryan brryan merged commit d01fe2c into develop Nov 24, 2024
4 checks passed
@brryan brryan deleted the dempsey/cleanup branch November 24, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brryan brryan brryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamdempsey90 @brryan