Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snprintf. Hide sprintf as fancy snprintf #71

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Add snprintf. Hide sprintf as fancy snprintf #71

merged 8 commits into from
Nov 25, 2024

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

Apparently compilers don't like us using sprintf because of the risk of writing arbitrary bits to memory. This switches portable_errors to using snprintf for error messages.

PR Checklist

  • Any changes to code are appropriately documented.
  • Code is formatted.
  • Install test passes.
  • Docs build.
  • If preparing for a new release, update the version in cmake.

@Yurlungur Yurlungur added the bug Something isn't working label Nov 22, 2024
@Yurlungur Yurlungur self-assigned this Nov 22, 2024
@Yurlungur Yurlungur merged commit 8fe3423 into main Nov 25, 2024
4 checks passed
@Yurlungur Yurlungur deleted the jmm/snprintf branch November 25, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrendanKKrueger BrendanKKrueger BrendanKKrueger approved these changes

@chadmeyer chadmeyer Awaiting requested review from chadmeyer

@mauneyc-LANL mauneyc-LANL Awaiting requested review from mauneyc-LANL

Assignees

@Yurlungur Yurlungur

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yurlungur @BrendanKKrueger @jonahm-LANL