-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JAX 3D X-ray CT projector #529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. I added a few nitpicking comments/suggestions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 94.67% 93.51% -1.16%
==========================================
Files 91 90 -1
Lines 5707 5780 +73
==========================================
+ Hits 5403 5405 +2
- Misses 304 375 +71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is worth discussing. It may be worth hiding the
Also worth discussing. The natural home for this would seem to be
Is the concern that |
54084d1
to
4351941
Compare
* Add typing, fix docstrings, change convert_to_scico_geometry interface * Improve docs * Bug fix * Fix function call in test
94723cf
to
9da091d
Compare
127ac7e
to
bcba849
Compare
See example results at https://scico--529.org.readthedocs.build/en/529/examples/ct_projector_comparison_3d.html
Still not clear why the back projections don't look like they match. It seems like calling
.transpose(2, 1, 0)
on the ASTRA back projection gets them closer. My best guess is that this example generates vectors that cause ASTRA back projection to get flipped. I do think SCICO's back projection is correct given that it comes from autograd.For consideration:
XRayTransform(Parallel3dProjector(in_shape, P, out_shape))
syntax too complex? I like that it separates the projector logic from SCICO (makes it easy to cut and paste into other projects), but it's awkward.XRayTransform