diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 34123969f3..8a77dd7792 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -10,6 +10,7 @@ variables: SINGULARITY_EOS_GCC_VERSION: "9.3.0" SINGULARITY_EOS_OPENMPI_VERSION: "4.1.3" SINGULARITY_EOS_CUDA_VERSION: "11.6.0" + SINGULARITY_EOS_BUILD_TYPE: "RelWithDebInfo" SINGULARITY_EOS_SPACK_SPEC: "singularity-eos@main+mpi+hdf5+python+tests%gcc@${SINGULARITY_EOS_GCC_VERSION} ^openmpi@${SINGULARITY_EOS_OPENMPI_VERSION}" COLOR_CYAN: '\033[1;36m' COLOR_PLAIN: '\033[0m' @@ -45,10 +46,13 @@ before_script: ########################## .buildtype_debug: &buildtype_debug - BUILD_TYPE: "Debug" + SINGULARITY_EOS_BUILD_TYPE: "Debug" .buildtype_release: &buildtype_release - BUILD_TYPE: "Release" + SINGULARITY_EOS_BUILD_TYPE: "Release" + +.buildtype_relDebugInfo: &buildtype_relDebugInfo + SINGULARITY_EOS_BUILD_TYPE: "RelWithDebInfo" .gpu: &gpu SINGULARITY_USE_CUDA: "true" @@ -133,6 +137,7 @@ before_script: - cd build - | cmake -DCMAKE_INSTALL_PREFIX=${CI_PROJECT_DIR}/install ${SINGULARITY_CMAKE_CXX_COMPILER_FLAG} \ + -DCMAKE_BUILD_TYPE=${SINGULARITY_EOS_BUILD_TYPE} \ -DSINGULARITY_USE_EOSPAC=ON \ -DSINGULARITY_USE_SPINER=ON \ -DSINGULARITY_USE_SPINER_WITH_HDF5=ON \ @@ -190,6 +195,7 @@ test_gnu_power9_gpu: extends: .test variables: <<: *power9 + <<: *buildtype_release <<: *gpu test_x86_volta_gpu: @@ -197,6 +203,7 @@ test_x86_volta_gpu: extends: .test variables: <<: *x86volta + <<: *buildtype_release <<: *gpu install_gnu_skylake_fort: diff --git a/CHANGELOG.md b/CHANGELOG.md index 1580521083..ba1c4ac246 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -43,6 +43,7 @@ ### Infrastructure (changes irrelevant to downstream codes) - [[PR190]](https://github.com/lanl/singularity-eos/pull/190) update CI on re-git +- [[PR245]](https://github.com/lanl/singularity-eos/pull/245) Separating get_sg_eos to other files. Build/compilation improvements, warning fixes/suppression. ### Removed (removing behavior/API/varaibles/...) diff --git a/cmake/submodule_configs.cmake b/cmake/submodule_configs.cmake index 303df4414b..64d4502b71 100644 --- a/cmake/submodule_configs.cmake +++ b/cmake/submodule_configs.cmake @@ -23,7 +23,6 @@ macro(singularity_cmake_config pkg) if(SINGULARITY_USE_CUDA) set(Kokkos_ENABLE_CUDA ON CACHE BOOL "" FORCE) set(Kokkos_ENABLE_CUDA_LAMBDA ON CACHE BOOL "" FORCE) - set(Kokkos_ENABLE_CUDA_RELOCATABLE_DEVICE_CODE ON CACHE BOOL "" FORCE) endif() elseif(${pkg} STREQUAL "KokkosKernels") # Disable TPLs diff --git a/singularity-eos/CMakeLists.txt b/singularity-eos/CMakeLists.txt index 285545c10e..f243d057f7 100644 --- a/singularity-eos/CMakeLists.txt +++ b/singularity-eos/CMakeLists.txt @@ -13,7 +13,6 @@ #------------------------------------------------------------------------------# set(EOS_HEADERS - closure/mixed_cell_models.hpp base/fast-math/logs.hpp base/robust_utils.hpp base/root-finding-1d/root_finding.hpp @@ -49,12 +48,28 @@ set(EOS_SRCS ) if (SINGULARITY_BUILD_CLOSURE) - list(APPEND EOS_SRCS eos/singularity_eos.cpp) - list(APPEND EOS_HEADERS eos/singularity_eos.hpp closure/mixed_cell_models.hpp) + list(APPEND EOS_HEADERS + closure/mixed_cell_models.hpp) + if (SINGULARITY_USE_FORTRAN) + list(APPEND EOS_SRCS + eos/get_sg_eos.cpp) + if (SINGULARITY_USE_KOKKOS) + list(APPEND EOS_SRCS + eos/get_sg_eos_p_t.cpp + eos/get_sg_eos_rho_t.cpp + eos/get_sg_eos_rho_p.cpp + eos/get_sg_eos_rho_e.cpp) + endif() + list(APPEND EOS_HEADERS + eos/get_sg_eos.hpp + eos/get_sg_eos_functors.hpp) + endif() endif() if (SINGULARITY_USE_FORTRAN) list(APPEND EOS_SRCS eos/singularity_eos.f90) + list(APPEND EOS_SRCS eos/singularity_eos.cpp) + list(APPEND EOS_HEADERS eos/singularity_eos.hpp) # would rather handle this more robustly, being sloppy for now list(APPEND EOS_MODS singularity_eos.mod singularity_eos_types.mod) endif() diff --git a/singularity-eos/base/variadic_utils.hpp b/singularity-eos/base/variadic_utils.hpp index 863fc355a6..2d1aa9f7de 100644 --- a/singularity-eos/base/variadic_utils.hpp +++ b/singularity-eos/base/variadic_utils.hpp @@ -68,10 +68,6 @@ struct flatten> { }; // filter nested variadic templates -template