Remove PTofRE implementations from source. Tests pass on my p9 darwin…

[dholladay00]

… node.

PR Summary

As discussed with @Yurlungur, this function was the sole reason for very excessive GPU compile times. The singular place it was used was replaced with an equivalent functionality. It does not appear to be used anywhere else.

This PR removes PTofRE function. I'd like to hear from folks downstream, @jdolence @jhp-lanl do you foresee issues with the removal of this function to downstream use cases and/or future use cases (PT table equivalent for example @jhp-lanl?)

PR Checklist

• Adds a test for any bugs fixed. Adds tests for new features.
• Format your changes by using the make format command after configuring with cmake.
• Document any new features, update documentation for changes made.
• Make sure the copyright notice on any files you modified is up to date.
• After creating a pull request, note it in the CHANGELOG.md file
• If preparing for a new release, update the version in cmake.

[Yurlungur]

To add some context, this function was originally written as a convenience for the flag-type PTE solver. But the current solvers don't use this function, and the same functionality is available as a collection of calls, or through FillEos.

While I believe we may need functions that compute quantities given Pressure as an input, this function doesn't provide it. So I see this as just removing code that (a) we don't need and shouldn't continue to maintain and (b) apparently slows compile times way down for some reason.

[Yurlungur]

The list of files changed doesn't seem like the entire list of Eoses and modifiers. Let's just make sure we got them all.

[dholladay00]

The list of files changed doesn't seem like the entire list of Eoses and modifiers. Let's just make sure we got them all.

I found things to remove via grep, so I think things that didn't include probably relied on the base implementation.

[jhp-lanl]

Obviously not a blocker for this MR: I'd like to understand why this was so bad at some point though so that we know what we can't feasibly do in the CRTP base class. Like is it a problem to call multiple class member functions there? Or is it a combination of that with the parallel for in the vector version? I suppose we'll find out whenever we try something that drastically increases compilation times 🙃

[jhp-lanl]

I think you left a dangling remnant of the documentation. Otherwise looks good

[Yurlungur]

@dholladay00 is this ready to go? I re-triggered the re-git pipelline

[dholladay00]

It should be, the reason the pipeline had failed was due to a timeout due to the inability to obtain an x86-v100 node in a timely manner.

[Yurlungur]

Tests passing. Pulling the trigger.