Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

Refactor constructor parameters for Client #40

Open
hassankhan opened this issue Jun 1, 2016 · 4 comments
Open

Refactor constructor parameters for Client #40

hassankhan opened this issue Jun 1, 2016 · 4 comments

Comments

@hassankhan
Copy link
Member

The constructor of Client needs to be refactored so a consumer can pass classes directly rather than providers.

@vinkla
Copy link
Contributor

vinkla commented Jun 1, 2016

Awesome stuff!

@rockfridrich
Copy link

Are there any thoughts how to implement this feature?

@hassankhan
Copy link
Member Author

hassankhan commented Jul 4, 2016

Hi, we agreed on changing the constructor to allow a new parameter called $collaborators. This would be an array, and the session_store and http_adapter values from $options should be moved to this instead.

@vinkla
Copy link
Contributor

vinkla commented Jul 5, 2016

@hassankhan let me know when you've something and then I can start implementing it in the Laravel wrapper.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants