Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "contructionYear" in real_estates #173

Open
Sigri44 opened this issue Feb 13, 2024 · 5 comments
Open

Add "contructionYear" in real_estates #173

Sigri44 opened this issue Feb 13, 2024 · 5 comments

Comments

@Sigri44
Copy link

Sigri44 commented Feb 13, 2024

Add "contructionYear" into real_estates, to be compatible with RealT constructionYear Data

@lasconic
Copy link
Owner

"contructionYear" is available in finary api ?

@lasconic
Copy link
Owner

lasconic commented Feb 13, 2024

I don't see constructionYear in Finary API. There is building_period that we don't support. It takes a finite list of options.
One of them is between_1975_1984

Typical payload of a POST on real_estates

{
  "is_automated_valuation": false,
  "is_furnished": false,
  "is_new": false,
  "has_lift": false,
  "has_sauna": false,
  "has_pool": false,
  "building_period": "between_1975_1984",
  "flooring_quality": null,
  "flooring_condition": null,
  "windows_quality": null,
  "windows_condition": null,
  "bathrooms_quality": null,
  "bathrooms_condition": null,
  "kitchen_quality": null,
  "kitchen_condition": null,
  "general_quality": null,
  "general_condition": null,
  "parking_spaces": null,
  "garage_spaces": null,
  "number_of_rooms": null,
  "number_of_bathrooms": null,
  "number_of_floors": null,
  "floor_number": null,
  "balcony_area": null,
  "garden_area": null,
  "category": "rent",
  "monthly_charges": 2,
  "monthly_rent": 100,
  "yearly_taxes": 2,
  "rental_period": "annual",
  "rental_type": "lmnp",
  "is_estimable": true,
  "user_estimated_value": null,
  "description": "dfdf",
  "surface": 40,
  "agency_fees": 12,
  "notary_fees": 12,
  "furnishing_fees": 12,
  "renovation_fees": 2,
  "buying_price": 10000,
  "building_type": "apartment",
  "ownership_percentage": 100,
  "place_id": "",
  "bought_at": "2024-02-01"
}

@Sigri44
Copy link
Author

Sigri44 commented Feb 13, 2024

Hum i don't know, but available on portfolio :
image

@nmathey
Copy link
Contributor

nmathey commented Mar 26, 2024

Might be this field:
"building_period": "between_1975_1984", ?

@lasconic
Copy link
Owner

Yes, we need a list of the possible value, and decide how we pass it to the function...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants