Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences with Lorentz Embeddings #1

Open
gokul-uf opened this issue Nov 1, 2018 · 2 comments
Open

Differences with Lorentz Embeddings #1

gokul-uf opened this issue Nov 1, 2018 · 2 comments

Comments

@gokul-uf
Copy link

gokul-uf commented Nov 1, 2018

Hi,
Thanks a lot for open-sourcing both this and the original poincare embeddings paper.

The authors of the original paper (poincare embeddings) have another trained on the hyperboloid.

Could you let me know what the differences between this repo and those paper are?

Thanks

@mleimeister
Copy link

Hi Gokul,

thanks a lot for your interest in the code. It indeed implements the model that is described in the second paper of Nickel/Kiela that you mention. The vector class represents points on the hyperboloid model and the function geodesic_update computes the exponential function given a point and a tangent vector. This is the same as equation 9 in the paper.

There is a small difference in the initialization, where we are sampling a tangent vector at the base point uniformly and map it by the exponential function vs. sampling the first n dimensions and fixing the last one to lie on the hyperboloid for Nickel/Kiela.

Also, there is no burnin implemented. To achieve this, you can run the training twice, as described here.

Let me know if you have further questions or encounter any problems with the code.

Best regards,
Matthias

@gokul-uf
Copy link
Author

gokul-uf commented Nov 5, 2018

Thanks for the clarification! I'm training with the poincare embeddings codebase now and it seems much faster than the gensim implementation :) I'm planning to train with lorentz embeddings this week. I was wondering if you folks had any benchmarks / results comparing with the numbers from the lorentz embeddings paper.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants