fix: Add Detox e2e tests. #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusinto
requested review from
kinyoklion and
louis-launchdarkly
as code owners
yusinto
commented
Dec 29, 2023
| npm_version: 9.5.0 | ||
| - id: release-common |
There was a problem hiding this comment.
This is a bug in the existing config. This step id should say release-sdk-server, but it says release-common instead. I think it's an artifact of copy pasting. The other packages suffer from the same bug and I've fixed them all too.
yusinto
commented
Dec 29, 2023
yusinto
commented
Dec 29, 2023
release-please-config.json
Outdated
There was a problem hiding this comment.
Adding bump-minor-pre-major now that the packages have been published as 0.1.x.
kinyoklion
reviewed
Jan 3, 2024
| 2. On a terminal: | ||
|
|
||
| ```shell | ||
| yarn && yarn start |
There was a problem hiding this comment.
I made a comment, but I need to understand where I actually start this. My assumption was e2e.
There was a problem hiding this comment.
This needs to be run at the example level. I will update this and also include the extra step to run the xcode build for ios to generate the necessary ios folder and install cocoapods.
kinyoklion
approved these changes
Jan 3, 2024
Merged
yusinto
pushed a commit
that referenced
this pull request
Jan 3, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>react-native-client-sdk: 0.1.4</summary> ## [0.1.4](react-native-client-sdk-v0.1.3...react-native-client-sdk-v0.1.4) (2024-01-03) ### Bug Fixes * Add Detox e2e tests. ([#340](#340)) ([e7b9d29](e7b9d29)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds e2e tests for ios using Detox. Please try running it following the example/README.
Additionally I also included some fixes for release-please to publish sdk-client and rn.
detox-ios.mov