Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Revert - Fix incompatibility with @types/node release. #649

Merged
merged 1 commit into from
Oct 31, 2024
Merged

chore: Revert - Fix incompatibility with @types/node release. #649

merged 1 commit into from
Oct 31, 2024

Conversation

kinyoklion
Copy link
Member

Reverts #646

@kinyoklion kinyoklion requested a review from a team as a code owner October 31, 2024 19:33
@kinyoklion
Copy link
Member Author

I'll commit override the other one.

@kinyoklion kinyoklion changed the title revert: Fix incompatibility with @types/node release. core: Revert - Fix incompatibility with @types/node release. Oct 31, 2024
@kinyoklion
Copy link
Member Author

Tagged as a chore as it was not released, so we can avoid including changes for either PR.

@github-actions GitHub Actions
Copy link
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 18517 bytes
Size limit: 21000

@kinyoklion kinyoklion changed the title core: Revert - Fix incompatibility with @types/node release. chore: Revert - Fix incompatibility with @types/node release. Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 19278 bytes
Size limit: 21000

@github-actions GitHub Actions
Copy link
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 15292 bytes
Size limit: 20000

@kinyoklion kinyoklion merged commit 473e0cb into main Oct 31, 2024
21 of 22 checks passed
@kinyoklion kinyoklion deleted the revert-646-rlamb/fix-node-typings branch October 31, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanderson-ld tanderson-ld tanderson-ld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinyoklion @tanderson-ld