From 3a4d8e734d25b0adea7e77d0b43c13f451059b6a Mon Sep 17 00:00:00 2001 From: "Matthew M. Keeler" Date: Wed, 20 Dec 2023 09:15:34 -0500 Subject: [PATCH] fix: Bump MSRV to 1.70.0 (#61) Co-authored-by: Casey Waldren --- .github/workflows/ci.yml | 4 ++-- .github/workflows/manual-publish.yml | 2 +- .github/workflows/release-please.yml | 2 +- README.md | 6 ++++++ contract-tests/Cargo.toml | 2 +- launchdarkly-server-sdk/Cargo.toml | 2 +- 6 files changed, 12 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ffb4f5b..7965331 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,7 +20,7 @@ jobs: - name: Setup rust tooling run: | - rustup override set 1.68 + rustup override set 1.70 rustup component add rustfmt clippy - uses: ./.github/actions/ci @@ -47,7 +47,7 @@ jobs: - name: Setup rust tooling run: | - rustup override set 1.68 + rustup override set 1.70 rustup component add rustfmt clippy rustup target add x86_64-unknown-linux-musl diff --git a/.github/workflows/manual-publish.yml b/.github/workflows/manual-publish.yml index b0d624e..d8aacd4 100644 --- a/.github/workflows/manual-publish.yml +++ b/.github/workflows/manual-publish.yml @@ -19,7 +19,7 @@ jobs: - name: Setup rust tooling run: | - rustup override set 1.68 + rustup override set 1.70 rustup component add rustfmt clippy - uses: ./.github/actions/ci diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index f4bf24b..adebc7c 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -28,7 +28,7 @@ jobs: - name: Setup rust tooling if: ${{ steps.release.outputs.releases_created }} run: | - rustup override set 1.68 + rustup override set 1.70 rustup component add rustfmt clippy - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.0.0 diff --git a/README.md b/README.md index 135ba7b..168ed72 100644 --- a/README.md +++ b/README.md @@ -24,6 +24,12 @@ cargo run --example EXAMPLE_NAME Read our [documentation](https://docs.launchdarkly.com) for in-depth instructions on configuring and using LaunchDarkly. You can also head straight to the [complete reference guide for this SDK](https://docs.launchdarkly.com/sdk/server-side/rust). +## Minimum Supported Rust Version + +This project aims to maintain compatibility with a Rust version that is at least six months old. + +Version updates may occur more frequently than the policy guideline states if external forces require it. For example, a CVE in a downstream dependency requiring an MSRV bump would be considered an acceptable reason to violate the six month guideline. + ## Testing We run integration tests for all our SDKs using a centralized test harness. This approach gives us the ability to test for consistency across SDKs, as well as test networking behavior in a long-running application. These tests cover each method in the SDK, and verify that event sending, flag evaluation, stream reconnection, and other aspects of the SDK all behave correctly. diff --git a/contract-tests/Cargo.toml b/contract-tests/Cargo.toml index db399eb..f3057c9 100644 --- a/contract-tests/Cargo.toml +++ b/contract-tests/Cargo.toml @@ -2,7 +2,7 @@ name = "contract-tests" version = "0.1.0" edition = "2021" -rust-version = "1.68.0" # MSRV +rust-version = "1.70.0" # MSRV license = "Apache-2.0" [dependencies] diff --git a/launchdarkly-server-sdk/Cargo.toml b/launchdarkly-server-sdk/Cargo.toml index ffcf135..9f4464f 100644 --- a/launchdarkly-server-sdk/Cargo.toml +++ b/launchdarkly-server-sdk/Cargo.toml @@ -4,7 +4,7 @@ description = "LaunchDarkly Server-Side SDK" version = "2.0.1" authors = ["LaunchDarkly"] edition = "2021" -rust-version = "1.68.0" # MSRV +rust-version = "1.70.0" # MSRV license = "Apache-2.0" homepage = "https://docs.launchdarkly.com/sdk/server-side/rust" repository = "https://github.com/launchdarkly/rust-server-sdk"