Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Wand funtionality #337

Open
AnthonyyHL opened this issue Dec 29, 2023 · 4 comments
Open

Magic Wand funtionality #337

AnthonyyHL opened this issue Dec 29, 2023 · 4 comments

Comments

@AnthonyyHL
Copy link
Contributor

Hi my name is Anthony Herrera!
I've been looking for repositories and then I found your project. I think it's amazing. I thought that a Magic Wand, would be very useful for users when they want to select specific shapes.

Magic Wand Selection

As you can see, if a person only wants to paint on the yellow part of the image, he just has to select it with the Magic Wand and paint on it.
If you consider to include this functionality to Pixelitor would be awesome!.

@AnthonyyHL
Copy link
Contributor Author

Here is the file's link. I couldn't upload it because of its size.
LINK: https://drive.google.com/file/d/120FR0YD1nYhO27YZ8pIQBBc9EY2fQKu1/view?usp=sharing

@lbalazscs
Copy link
Owner

Hi Anthony,

I think it's great that you're interested in contributing the Magic Wand feature to Pixelitor! However, instead of sending a Google Drive link, it would be more effective if you could create a pull request. Typically, this is the preferred method for making contributions on GitHub. This way, I can see better what changed, and anyone can easily see that you've contributed to Pixelitor. I also noticed that your GitHub fork of Pixelitor isn't based on the latest Pixelitor release. Would you mind rebasing it?

If you have never done such rebasing before, please read the first answer to this question: https://stackoverflow.com/questions/7244321/how-do-i-update-or-sync-a-forked-repository-on-github

After you rebased it, please create a pull request on GitHub. If you have never done pull requests, there are many tutorials on the web. If you need more help with either the rebasing or creating a pull request, let me know! I'm looking forward to collaborating on this exciting feature.

Regards,
Laszlo

@AnthonyyHL
Copy link
Contributor Author

Hi Laszlo!

Thanks for the link, I checked it out and could rebase my fork. I'm now going to submit a pull request so you can see the changes I've made for the feature.

@lbalazscs
Copy link
Owner

Great! I merged the PR (#338), and I also commented on it about some remaining issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants