Issue2048 boiler plant condensation control #2156
Conversation
…ences Issue1925 staging boiler plant sequences
…ences Issue1925 staging boiler plant sequences
…uences Issue1925 staging boiler plant sequences
…nces' into issue1925
…ithub.com/lbl-srg/modelica-buildings into lbl-srg-issue2048_BoilerPlant_CondensationControl
… issue2048_BoilerPlant_CondensationControl
|
@milicag: Hi Milica, this pull request is ready for review. |
| block CondensationControl | ||
| "Sequence to calculate setpoint limits for condensation control in non-condesing boilers" | ||
|
|
||
| parameter Boolean primaryOnly = false |
| parameter Boolean primaryOnly = false | ||
| "True: Primary-only plant; False: Primary-secondary plant"; | ||
|
|
||
| parameter Boolean variablePrimary = true |
| "Minimum secondary pump speed"; | ||
|
|
||
| parameter Real minPriPumSpeSta[nSta]( | ||
| final unit="1", |
There was a problem hiding this comment.
Please use final unit=fill("1", nSta) and equivalent edits to all attributes of a vectorized parameter. For now we also use for any such parameters an annotation such as this one: annotation (Evaluate=true);. This annotation will become obsolete once this issue has been resolved and we will do a refactor to remove it then.
| "Vector of minimum primary pump speed for each stage"; | ||
|
|
||
| Buildings.Controls.OBC.CDL.Interfaces.IntegerInput uCurSta | ||
| "Current stage" |
There was a problem hiding this comment.
Is there a reason not to use uSta?
| annotation (Placement(transformation(extent={{100,-20},{140,20}}), | ||
| iconTransformation(extent={{100,-20},{140,20}}))); | ||
|
|
||
| Buildings.Controls.OBC.CDL.Interfaces.RealOutput yMaxSecPumSpe( |
There was a problem hiding this comment.
Based on the conventions please place Min or Max always as a suffix (unless you have a suffix with a leading underscore to use after it, for example _flow for any flow variables.). Here for example you should name the output ySecPumSpeMax.
| annotation (Placement(transformation(extent={{-140,-20},{-100,20}}), | ||
| iconTransformation(extent={{-140,-20},{-100,20}}))); | ||
|
|
||
| Buildings.Controls.OBC.CDL.Interfaces.RealOutput yRegSig( |
There was a problem hiding this comment.
Could this be only y, as the model name indicates it is a regulator signal?
| annotation (Placement(transformation(extent={{-60,-10},{-40,10}}))); | ||
|
|
||
| Buildings.Controls.OBC.CDL.Continuous.Limiter lim( | ||
| final uMax=TRetSet - TRetMinAll, |
There was a problem hiding this comment.
This is not permitted in CDL. You could use min/max and have it be an input.
| "Minimum secondary pump speed"; | ||
|
|
||
| parameter Real minPriPumSpeSta[nSta]( | ||
| final unit="1", |
There was a problem hiding this comment.
again the vectorization of the values assigned to attributes in needed.
|
|
||
| Buildings.Controls.OBC.CDL.Continuous.AddParameter addPar3( | ||
| final p=1, | ||
| final k=(minSecPumSpe - 1)) if variablePrimary |
There was a problem hiding this comment.
@JayHuLBL Please correct me if I am wrong. I believe the translator cannot handle such expressions.
| within Buildings.Controls.OBC.ASHRAE.PrimarySystem.BoilerPlant; | ||
| package SetPoints | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove all but one empty line.
|
Closing pull request since all sequences will be pulled through #2193. |
No description provided.