Code

Issue3492 direct evaporative cooler#3755

Code

Draft

JayHuLBL wants to merge 107 commits intomasterlbl-srg/modelica-buildings:masterfrom issue3492_DirectEvaporativeCoolerlbl-srg/modelica-buildings:issue3492_DirectEvaporativeCoolerCopy head branch name to clipboard

+10,292

Commits

Commits on Sep 1, 2020

• Merge pull request #20 from lbl-srg/master

  Show description for a432926
  karthikeyad-pnnl

  authored
  a432926

Commits on Jun 7, 2021

• Merge remote-tracking branch 'upstream/master'

  karthikeyad-pnnl

  committed
  3b2b6ca

Commits on Sep 15, 2021

• Merge remote-tracking branch 'upstream/master'

  karthikeyad-pnnl

  committed
  7f9c083

Commits on Oct 6, 2021

• Merge remote-tracking branch 'upstream_local/master'

  karthikeyad-pnnl

  committed
  b8b08fe

Commits on Oct 25, 2021

• Merge branch 'lbl-srg:master' into master

  karthikeyad-pnnl

  authored
  53454bf

Commits on Nov 9, 2021

• Merge branch 'lbl-srg:master' into master

  karthikeyad-pnnl

  authored
  45d798b

Commits on Jan 26, 2022

• Merge branch 'lbl-srg:master' into master

  karthikeyad-pnnl

  authored
  ec99cc6

Commits on Feb 14, 2022

• Merge branch 'lbl-srg:master' into master

  karthikeyad-pnnl

  authored
  b5ae2ff

Commits on Jul 15, 2022

• Merge branch 'lbl-srg:master' into master

  karthikeyad-pnnl

  authored
  bc9857c

Commits on Aug 2, 2022

• Merge remote-tracking branch 'upstream/master'

  karthikeyad-pnnl

  committed
  e59ff2a

Commits on Jun 27, 2023

• Merge pull request #79 from lbl-srg/master

  Show description for 7b5cf41
  karthikeyad-pnnl

  authored
  7b5cf41

Commits on Jul 11, 2023

• Merge branch 'lbl-srg:master' into master

  karthikeyad-pnnl

  authored
  bdaf8e0

Commits on Aug 29, 2023

• Merge branch 'lbl-srg:master' into master

  karthikeyad-pnnl

  authored
  50476d0

Commits on Aug 30, 2023

• Added direct evaporative cooler blocks to Buildings library

  karthikeyad-pnnl

  committed
  2286744

• Merge branch 'lbl-srg:master' into issue3492_DirectEvaporativeCooler

  karthikeyad-pnnl

  authored
  15f7242

Commits on Aug 31, 2023

• Change path for missing blocks.

  lzwang26

  committed
  82d4872

• Change istance names of the models.

  lzwang26

  committed
  ab30959

Commits on Sep 1, 2023

• Add comments for variables and parameters in model 'DirectCalculations'

  lzwang26

  committed
  77555e3

• Clean block 'DirectCalculations' according to the conventions.

  lzwang26

  committed
  e80f545

Commits on Sep 2, 2023

• Clean the model 'Direct'

  lzwang26

  committed
  756a60f

Commits on Sep 6, 2023

• Add documentations and icons

  lzwang26

  committed
  76ece54

Commits on Sep 9, 2023

• Add documentations.

  lzwang26

  committed
  f5af7c1

Commits on Sep 12, 2023

• Merge pull request #85 from lzwang26/issue3492_DirectEvaporativeCooler

  Show description for c36f05d
  karthikeyad-pnnl

  authored
  c36f05d

• Added validation scripts and modified validation model for direct evaporative cooler calculations

  karthikeyad-pnnl

  committed
  8e12210

• Updated resources and scripts for validation models

  karthikeyad-pnnl

  committed
  d24661e

Commits on Sep 14, 2023

• Merge pull request #1 from karthikeyad-pnnl/issue3492_DirectEvaporativeCooler

  Show description for 23ba270
  lzwang26

  authored
  23ba270

• Further clean up the model 'Xi_TDryBulTWetBul'

  lzwang26

  committed
  a9346c9

• Further clean up the model 'DirectCalculations'

  lzwang26

  committed
  f33ec8a

• Further clean up the model 'Direct'

  lzwang26

  committed
  663f34d

• Clean up the model 'Validation.DirectCalculations'

  lzwang26

  committed
  1a538a5

• Clean up the model 'Validation.DirectCalculations'

  lzwang26

  committed
  f3764ee

• Clean up the model 'Validation.Direct'

  lzwang26

  committed
  d282647

• Add documentation for the direct calculation validation.

  lzwang26

  committed
  e91ab53

• Finalized the documentations for all the models.

  lzwang26

  committed
  4e7d5b1

• Merge branch 'issue3492_DirectEvaporativeCooler' of https://github.com/lzwang26/modelica-buildings into issue3492_DirectEvaporativeCooler

  lzwang26

  committed
  7346572

Commits on Sep 15, 2023

• Correct the path of DirectCalculations.mos

  lzwang26

  committed
  bf409d6

• Add the script file.

  lzwang26

  committed
  449ec7d

Commits on Sep 16, 2023

• Merge pull request #87 from lzwang26/issue3492_DirectEvaporativeCooler

  Show description for 697971d
  karthikeyad-pnnl

  authored
  697971d

Commits on Sep 19, 2023

• Added files for indirect dry evaporative cooler

  karthikeyad-pnnl

  committed
  35911fb

Commits on Sep 20, 2023

• Updated models and added validation script and reference data

  karthikeyad-pnnl

  committed
  54e897c

• Merge pull request #2 from karthikeyad-pnnl/issue3492_DirectEvaporativeCooler

  Show description for 42c8673
  lzwang26

  authored
  42c8673

• Revise the documentation of 'Baseclasses.Validation.DirectCalculations'

  lzwang26

  committed
  5419ec8

• Revise the documentation of 'Validation.Direct'

  lzwang26

  committed
  6a6fe59

• Clean up IndirectDry model

  lzwang26

  committed
  689f601

• Clean up Validation.IndirectDry

  lzwang26

  committed
  8c252ba

• Add documentation and revision for 'IndirectDry'

  lzwang26

  committed
  f898a2b

• Add documentations for 'Validation.IndirectDry'

  lzwang26

  committed
  ddbd8dd

Commits on Sep 21, 2023

• Correct some errors.

  lzwang26

  committed
  56c0e2b

• Merge pull request #89 from lzwang26/issue3492_DirectEvaporativeCooler

  Show description for 98b324c
  karthikeyad-pnnl

  authored
  98b324c

Commits on Sep 22, 2023

• Added new clas for indirect wet cooler

  karthikeyad-pnnl

  committed
  b12878d

Commits on Sep 27, 2023

• Backing files up

  karthikeyad-pnnl

  committed
  f51c0be

Commits on Sep 29, 2023

• Backing up files

  karthikeyad-pnnl

  committed
  8eda1b9

• Updated formatting and documentation

  karthikeyad-pnnl

  committed
  a552549

• Updated package order files and added default component names

  karthikeyad-pnnl

  committed
  971cfb8

• Addded tolerances to validation models

  karthikeyad-pnnl

  committed
  e72321b

Commits on Sep 30, 2023

• Added unit test results

  karthikeyad-pnnl

  committed
  1b40511

Commits on Oct 2, 2023

• Merge pull request #2 from karthikeyad-pnnl/issue3492_DirectEvaporativeCooler

  Show description for 3d3f7e0
  cerrinamouchref-pnnl

  authored
  3d3f7e0

Commits on Oct 3, 2023

• updated files to address comments on PR

  cerrinamouchref-pnnl

  committed
  ca28a08

Commits on Oct 4, 2023

• Updated file paths for validation reference data

  karthikeyad-pnnl

  committed
  4921db9

• Added pending unit test results

  karthikeyad-pnnl

  committed
  9a3e1c2

• Reverted files that did not have any changes in current PR

  karthikeyad-pnnl

  committed
  808cabf

• Reverted file that was not being changed through PR

  karthikeyad-pnnl

  committed
  d6728b4

• Updated Naming to address comments

  cerrinamouchref-pnnl

  committed
  e0d4237

Commits on Oct 5, 2023

• Merge pull request #97 from cerrinamouchref-pnnl/issue3492_DirectEvaporativeCooler

  Show description for b4bb7a3
  karthikeyad-pnnl

  authored
  b4bb7a3

Commits on Oct 6, 2023

• changes to validation models based on PR comments

  cerrinamouchref-pnnl

  committed
  683685b

Commits on Oct 9, 2023

• Changed instance names as per comment on PR

  karthikeyad-pnnl

  committed
  373c45d

• Merge branch 'issue3492_DirectEvaporativeCooler' into issue3492_DirectEvaporativeCooler_CerrinaRemote

  karthikeyad-pnnl

  committed
  4f4aba3

• Removed unnecessary changes

  karthikeyad-pnnl

  committed
  88f5deb

• Removed unnecessary formatting changes

  karthikeyad-pnnl

  committed
  86f3e0d

• Merge pull request #98 from karthikeyad-pnnl/issue3492_DirectEvaporativeCooler_CerrinaRemote

  Show description for b62fe5c
  karthikeyad-pnnl

  authored
  b62fe5c

Commits on Jan 16, 2024

• Addressed comment 'Dry bulb temperature of the inlet air'

  lzwang26

  committed
  32d717a

• Address comments 'Dry bulb temperature of the primary inlet air'

  lzwang26

  committed
  a1fd359

Commits on Jan 26, 2024

• Delte algorithm assignments

  lzwang26

  committed
  925e73d

• Change equation to connect in Baseclasses.DirectCalculations.mo

  lzwang26

  committed
  0a72565

• delete visible = true in Baseclasses.IndirectWetCalculations.mo

  lzwang26

  committed
  a3fbada

Commits on Jan 31, 2024

• Updated unit test results

  lzwang26

  committed
  7f31be3

• Modified DirectCalculations.mo

  lzwang26

  committed
  6b01c91

Commits on Feb 20, 2024

• Merge pull request #116 from lzwang26/issue3492_DirectEvaporativeCooler

  Show description for c48211b
  karthikeyad-pnnl

  authored
  c48211b

• Merge pull request #123 from lbl-srg/issue3492_DirectEvaporativeCooler

  Show description for 6082fe7
  karthikeyad-pnnl

  authored
  6082fe7

• Removed redundant variable

  karthikeyad-pnnl

  committed
  17c66d1

• Merge branch 'issue3492_DirectEvaporativeCooler' of github.com:karthikeyad-pnnl/modelica-buildings into issue3492_DirectEvaporativeCooler

  karthikeyad-pnnl

  committed
  6aea34b

• Moved validation instance to start of model

  karthikeyad-pnnl

  committed
  ff028c7

• Updated documentation sections for all models

  karthikeyad-pnnl

  committed
  0229f85

Commits on Mar 28, 2024

• Merge pull request #3543 from karthikeyad-pnnl/issue3492_DirectEvaporativeCooler

  Show description for 972e798
  JayHuLBL

  authored
  972e798

• Merge branch 'master' into issue3492_DirectEvaporativeCooler

  JayHuLBL

  committed
  cd7b2c2

Commits on Mar 29, 2024

• improving text

  JayHuLBL

  committed
  edb384e

• improved text [ci skip]

  JayHuLBL

  committed
  990fcfa

Commits on Apr 8, 2024

• changed text format [ci skip]

  JayHuLBL

  committed
  d4a842a

Commits on May 2, 2024

• Updated models a per comments on PR #3755. Added missing comments to validation instances

  karthikeyad-pnnl

  committed
  3aa436f

• Updated unit test results

  karthikeyad-pnnl

  committed
  a7a895b

Commits on Aug 22, 2024

• Merge pull request #3820 from karthikeyad-pnnl/issue3492_DirectEvaporativeCooler

  Show description for aaebf5e
  JayHuLBL

  authored
  aaebf5e

• Merge branch 'issue3492_DirectEvaporativeCooler' of https://github.com/lbl-srg/modelica-buildings into issue3492_DirectEvaporativeCooler

  JayHuLBL

  committed
  5d6ad17

• Merge branch 'master' into issue3492_DirectEvaporativeCooler

  JayHuLBL

  committed
  4e4162f

Commits on Aug 23, 2024

• merged master, corrected units

  JayHuLBL

  committed
  54ad1ea

• Removed BOMs

  JayHuLBL

  committed
  7c47337

• corrected results plots

  JayHuLBL

  committed
  6abf772

• added start time

  JayHuLBL

  committed
  bee6fa6

• changed the file permission

  JayHuLBL

  committed
  82516f2

Commits on Nov 1, 2024

• Updated extended baseclasses and state measurements as per the comments on #3755

  karthikeyad-pnnl

  committed
  2fd64d2

• Merge branch 'issue3492_DirectEvaporativeCooler' of github.com:lbl-srg/modelica-buildings into lbl-srg-issue3492_DirectEvaporativeCooler

  karthikeyad-pnnl

  committed
  f393bf5

• Merge branch 'lbl-srg-issue3492_DirectEvaporativeCooler' into issue3492_DirectEvaporativeCooler

  karthikeyad-pnnl

  committed
  4c71fcd

Commits on Nov 21, 2024

• Added pass-through block to overcome error caused by unit mismatch

  karthikeyad-pnnl

  committed
  486ba50

• Made simulation time uniform across all validation models

  karthikeyad-pnnl

  committed
  3ae477f

Commits on Nov 22, 2024

• Updated unit test results

  

  junkewang001

  authored and

  karthikeyad-pnnl

  committed
  0a94a5d

• Changed display unit parameters to unit parameters

  karthikeyad-pnnl

  committed
  6b66f4a

Commits on Nov 25, 2024

• Merge pull request #4056 from karthikeyad-pnnl/issue3492_DirectEvaporativeCooler

  Show description for 7628455
  JayHuLBL

  authored
  7628455

• updated reference

  JayHuLBL

  committed
  4f64da5