From c72e4e767faffed895f7a9010e2fc0dd0eea3f2b Mon Sep 17 00:00:00 2001
From: lcomplete <louchenabc@gmail.com>
Date: Tue, 28 Mar 2023 18:06:21 +0800
Subject: [PATCH] chore: change setting button position in electron app

---
 app/client/src/components/Header.tsx | 25 +++++++++++++++----------
 app/client/src/styles/globals.css    |  3 +++
 2 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/app/client/src/components/Header.tsx b/app/client/src/components/Header.tsx
index ef2bdd4..13e9d32 100644
--- a/app/client/src/components/Header.tsx
+++ b/app/client/src/components/Header.tsx
@@ -11,11 +11,11 @@ export default function Header() {
   const [fullScreen, setFullScreen] = useState(false);
   const [focused, setFocused] = useState(false);
   const [settingModalOpen, setSettingModalOpen] = useState(false);
-  const inBrowser = !window.electron;
-  const isMac = !inBrowser && window.electron.utilsBridge.isMac;
+  const inElectron = !!window.electron;
+  const isMac = inElectron && window.electron.utilsBridge.isMac;
 
   useEffect(() => {
-    if (inBrowser) {
+    if (!inElectron) {
       return;
     }
     const {utilsBridge} = window.electron;
@@ -51,10 +51,10 @@ export default function Header() {
   const openSettingModal = useCallback(() => {
     setSettingModalOpen(true);
   }, []);
-  
-  const closeSettingModal = useCallback(()=>{
+
+  const closeSettingModal = useCallback(() => {
     setSettingModalOpen(false);
-  },[]);
+  }, []);
 
   return <header className="title_bar">
     {!isMac && (
@@ -66,14 +66,19 @@ export default function Header() {
 
     <SearchBox/>
 
-    <IconButton className={'mr-2 absolute right-0'} onClick={openSettingModal}>
-      <SettingsOutlinedIcon className={'text-sky-600'}/>
-    </IconButton>
+    {
+      (!inElectron || isMac) && <IconButton className={'mr-2 absolute right-0'} onClick={openSettingModal}>
+        <SettingsOutlinedIcon className={'text-sky-600'}/>
+      </IconButton>
+    }
 
     <SettingModal open={settingModalOpen} onClose={closeSettingModal}></SettingModal>
 
-    {!isMac && !inBrowser && (
+    {!isMac && inElectron && (
       <div className="absolute right-0">
+        <IconButton className={'mr-2 nodrag'} onClick={openSettingModal}>
+          <SettingsOutlinedIcon className={'text-sky-600'}/>
+        </IconButton>
         <button className="btn-size-ctrl" onClick={minimize}>
           {/* <HorizontalRuleIcon fontSize="small" /> */}
           <svg viewBox="0 0 11 11">
diff --git a/app/client/src/styles/globals.css b/app/client/src/styles/globals.css
index 1d368b5..c7f83f3 100644
--- a/app/client/src/styles/globals.css
+++ b/app/client/src/styles/globals.css
@@ -56,6 +56,9 @@ a{
 .search-wrapper{
   -webkit-app-region: no-drag;
 }
+.nodrag{
+  -webkit-app-region: no-drag;
+}
 
 .main_window{
   margin-left: 270px;