Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Tinkers Leveling [$5 awarded] #553

Closed
kedamono opened this issue Feb 6, 2017 · 3 comments
Closed

[Feature Request] Tinkers Leveling [$5 awarded] #553

kedamono opened this issue Feb 6, 2017 · 3 comments
Labels
Bounty Issues that currently have a bounty placed on them

Comments

@kedamono
Copy link

kedamono commented Feb 6, 2017

Minecolonies version

version 0.6.2595

Expected behavior

  • As workers use Tinker's Construct tools, such as the Hatchet, the tool will level with use.

Actual behaviour

  • The tool does not level.

Reasons for this request

It would nice if the workers could level Tinkers Tools using Tinkers Leveling. It would allow the player to upgrade the tool with more "features" from Tinkers making the tool more valuable for use by the worker.

Right now, I have to use a tool to level it up, but never at the rate the colonist use tools. I do understand that this would be difficult, as the leveling requires XP and other mechanisms implemented by Tinkers Leveling.

But, it would be nice to have.

Bountysource


The $5 bounty on this issue has been claimed at Bountysource.

@marvin-bitterlich
Copy link
Member

We would need to create a fakeplayer for this as it seems. And that was not a good solution. Tinkers wanted to change that at some point but for now they won't.

We should make a general issue for all the mod support issues I guess. Would be nice to have a bounty on that one then.

@marvin-bitterlich marvin-bitterlich changed the title [Feature Request] Tinkers Leveling [Feature Request] Tinkers Leveling [$5] Feb 7, 2017
@marvin-bitterlich marvin-bitterlich added the Bounty Issues that currently have a bounty placed on them label Feb 7, 2017
@DarVillous
Copy link
Contributor

Tinkers tool leveling currently checks to see if the entity using the tool is a player before applying XP.
The MoodToolLeveling.java has several checks to see if the EntityLivingBase is an instance of EntityPlayer. Tinkers construct itself might also have code that would need to change.

SlimeKnights/TinkersToolLeveling#89

@Raycoms
Copy link
Contributor

Raycoms commented Jan 2, 2019

Difficult and OP, I think we should just leave this.

@Raycoms Raycoms closed this as completed Jan 2, 2019
@marvin-bitterlich marvin-bitterlich changed the title [Feature Request] Tinkers Leveling [$5] [Feature Request] Tinkers Leveling [$5 awarded] Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty Issues that currently have a bounty placed on them
Projects
None yet
Development

No branches or pull requests

4 participants