Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Consider not storing sensitive information on LocalStorage if the tradeoff pays off #36

Open
lealceldeiro opened this issue Apr 11, 2020 · 1 comment
Assignees
Labels
bug client Issues related to the frontend.

Comments

@lealceldeiro
Copy link
Owner

Describe the bug
Sensitive information stored in the local-storage can be stolen by using an XSS attack

To Reproduce

  • Follow attack demos in the linked source

Expected behavior
Do not store sensitive information such as username, security tokens, etc, in local storage.

Instead it can be used:

  • Cookies and use the HTTPOnly and Secure flags
  • Session storage

Additional context
Consider modifying some of the classes involved in the front-end in storing this kind of sensitive information. i.e.:

  • SessionService
@lealceldeiro lealceldeiro added bug client Issues related to the frontend. labels Apr 11, 2020
@lealceldeiro lealceldeiro self-assigned this Apr 11, 2020
@lealceldeiro lealceldeiro changed the title Do not store sensitive information on LocalStorage Consider not storing sensitive information on LocalStorage if the tradeoff pays off Apr 11, 2020
@lealceldeiro
Copy link
Owner Author

A good source of other references link is https://stackoverflow.com/a/35347022/5640649

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug client Issues related to the frontend.
Projects
None yet
Development

No branches or pull requests

1 participant