Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_by_conversation 使用了 rtm v1 废弃的 max_ts 参数 #415

Open
weakish opened this issue Jul 23, 2019 · 0 comments
Open

find_by_conversation 使用了 rtm v1 废弃的 max_ts 参数 #415

weakish opened this issue Jul 23, 2019 · 0 comments
Labels
next breaking changes

Comments

@weakish
Copy link
Contributor

weakish commented Jul 23, 2019 •
edited
Loading

find_by_client 和 find_all 也有同样的问题。
weakish added a commit to weakish/docs that referenced this issue Jul 23, 2019
@weakish
fix(rtm): remove after_time & after_message_id
7174bef 
Do not list `after_time` & `after_message_id` parametrs for methods:

- find_by_conversation
- find_by_client
- find_all

First, the parameters are wrong.
The parameters declared in SDK are actually
**before**_time & **before**_message_id.

Second, these parameters use deperated `max_ts` parameter of REST API.
See also leancloud/python-sdk#415
weakish added a commit to weakish/docs that referenced this issue Jul 23, 2019
@weakish
fix(rtm): remove after_time & after_message_id
0c60f0d 
Do not list `after_time` & `after_message_id` parametrs for methods:

- find_by_conversation
- find_by_client
- find_all

First, the parameters are wrong.
The parameters declared in SDK are actually
**before**_time & **before**_message_id.

Second, these parameters use deperated `max_ts` parameter of REST API.
See also leancloud/python-sdk#415
@weakish weakish added the next breaking changes label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next breaking changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weakish