New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

清理一下 User 类下的方法 #436

Open

weakish opened this issue Dec 13, 2019 · 0 comments

Labels

next

Contributor

weakish commented Dec 13, 2019

比如：

大量的 request_xxx class method 没有使用 class、instance 信息，直接发一个请求，其实是 static method。这些方法中，部分应该改成 static method，部分应该改成实例方法，并更新实例的相应字段，比如 emailVerified 之类。
login 是实例方法，login_with_mobile_phone 却是 class method，这样的不一致性并不必要。可以废弃 login_with_mobile_phone，并入 login 方法（增加一个 mobile 参数）。

weakish added the next label

weakish mentioned this issue

查询 _Follow 表时带上 sessionToken #449

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment