Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All 'areacello' data failed tests. #146

Open
1 task
jbusecke opened this issue May 3, 2024 · 2 comments
Open
1 task

All 'areacello' data failed tests. #146

jbusecke opened this issue May 3, 2024 · 2 comments
Labels

Comments

@jbusecke
Copy link
Collaborator

jbusecke commented May 3, 2024

I just noticed when looking for the variable areacello that all the legacy stores are in out non-qc catalog.

I suspect that this is an error in the tests (likely some assumption about time being in the dimensions).

  • This will require some way to efficiently rerun test over all datasets (except retracted ones) after adjustments have been made to the testing.
@jbusecke
Copy link
Collaborator Author

jbusecke commented May 3, 2024

Yeah this seems like it would fail if there is no time present in the dataset.

@briochemc
Copy link

briochemc commented Sep 27, 2024

+1 for areacello!

It should be OK to only test "failed" data if a PR fixing this issue only removes tests (skips the time test if there is no time dimension), right? (I'm just asking, I may be confused as I don't really understand much of how this all works 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants